From: Keith Busch <kbusch@kernel.org>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Misc fixes on registering PCI NVMe CMB
Date: Mon, 24 Feb 2025 17:24:35 -0700 [thread overview]
Message-ID: <Z70Nw_RQ5C1sHiCV@kbusch-mbp> (raw)
In-Reply-To: <20250212170444.16138-1-uwu@icenowy.me>
On Thu, Feb 13, 2025 at 01:04:42AM +0800, Icenowy Zheng wrote:
> Here is a small patchset that is developed during my investigation of
> a WARNING in my boot kernel log (AMD EPYC 7K62 CPU + Intel DC D4502
> SSD), which is because of the SSD's too-small CMB block (512KB only).
>
> The first patch is a fix of the PCI DMA registration error handling
> codepath, which is just a observation-based patch (because my disk is
> only NVMe 1.2 compliant, and the register cleaned up here is only added
> in NVMe 1.4).
>
> The second patch really fixes the warning by testing the CMB block
> against the memory hotplugging alignment requirement (which the CMB
> block of my SSD surely cannot satisfy -- the alignment requirement is
> usually 2M with SPAREMEM_VMEMMAP enabled and even larger in other cases).
Applied to nvme-6.14 with the suggested changes in patch 2 folded in.
prev parent reply other threads:[~2025-02-25 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 17:04 [PATCH 0/2] Misc fixes on registering PCI NVMe CMB Icenowy Zheng
2025-02-12 17:04 ` [PATCH 1/2] nvme-pci: clean up CMBMSC when registering CMB fails Icenowy Zheng
2025-02-13 5:55 ` Christoph Hellwig
2025-02-12 17:04 ` [PATCH 2/2] nvme-pci: skip CMB blocks incompatible with PCI P2P DMA Icenowy Zheng
2025-02-13 5:58 ` Christoph Hellwig
2025-02-13 14:12 ` Icenowy Zheng
2025-02-13 5:54 ` [PATCH 0/2] Misc fixes on registering PCI NVMe CMB Christoph Hellwig
2025-02-13 6:05 ` Icenowy Zheng
2025-02-25 0:17 ` Keith Busch
2025-02-25 2:07 ` Icenowy Zheng
2025-02-25 0:24 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z70Nw_RQ5C1sHiCV@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.