From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, michel@lespinasse.org,
richard.weiyang@gmail.com
Subject: Re: + lib-interval_tree-skip-the-check-before-go-to-the-right-subtree.patch added to mm-nonmm-unstable branch
Date: Tue, 25 Feb 2025 12:35:29 +0000 [thread overview]
Message-ID: <Z725ERN5KDAANgD6@casper.infradead.org> (raw)
In-Reply-To: <20250225042234.AC256C4CEDD@smtp.kernel.org>
On Mon, Feb 24, 2025 at 08:22:34PM -0800, Andrew Morton wrote:
> The patch titled
> Subject: lib/interval_tree: skip the check before go to the right subtree
> has been added to the -mm mm-nonmm-unstable branch. Its filename is
> lib-interval_tree-skip-the-check-before-go-to-the-right-subtree.patch
I don't think this patch should be added. There's no claim of any
performance win. Wei has a long history of tweaky little patches that
may or may not be buggy. The interval tree has been around a long time
and doesn't have a test suite. This feels like unnecessary risk.
next prev parent reply other threads:[~2025-02-25 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 4:22 + lib-interval_tree-skip-the-check-before-go-to-the-right-subtree.patch added to mm-nonmm-unstable branch Andrew Morton
2025-02-25 12:35 ` Matthew Wilcox [this message]
2025-02-26 2:22 ` Wei Yang
2025-02-26 4:33 ` Matthew Wilcox
2025-02-26 13:19 ` Wei Yang
2025-02-27 22:59 ` Michel Lespinasse
2025-02-28 0:06 ` Wei Yang
-- strict thread matches above, loose matches on Subject: below --
2025-03-11 18:50 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z725ERN5KDAANgD6@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=michel@lespinasse.org \
--cc=mm-commits@vger.kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.