All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Michael Jeanson <mjeanson@efficios.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rseq: update kernel fields in lockstep with CONFIG_DEBUG_RSEQ
Date: Tue, 25 Feb 2025 10:12:01 +0100	[thread overview]
Message-ID: <Z72JYW0y7fUBSWll@gmail.com> (raw)
In-Reply-To: <26dba55c-eb09-4e9e-8460-8adbf75e32cd@efficios.com>


* Michael Jeanson <mjeanson@efficios.com> wrote:

> >> I always find it odd that the "source" argument comes first and 
> >> the "destination" argument comes second in all put_user() APIs, 
> >> compared to memcpy, WRITE_ONCE() and all assignments (e.g. 
> >> operator "=" LHS vs RHS). Choosing a different argument order 
> >> therefore made sense with a naming different from "*put_user", but 
> >> not so much if we use a derived naming.
> > 
> > Yeah, put_user()'s oddity is a random historic idiosyncrasy that we 
> > want to preserve in derived naming to reduce the potential for 
> > confusion.
> 
> Would that be ok?
> 
>   rseq_unsafe_put_user(t, value, field, error_label)

Yeah, I think so.

Thanks,

	Ingo

      reply	other threads:[~2025-02-25  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 19:13 [PATCH] rseq: update kernel fields in lockstep with CONFIG_DEBUG_RSEQ Michael Jeanson
2025-02-22 13:27 ` Ingo Molnar
2025-02-22 13:56   ` Mathieu Desnoyers
2025-02-22 14:12     ` Ingo Molnar
2025-02-24 20:40       ` Michael Jeanson
2025-02-25  9:12         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z72JYW0y7fUBSWll@gmail.com \
    --to=mingo@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mjeanson@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.