All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] payload: return early if dependency is not a payload expression
Date: Wed, 26 Feb 2025 00:22:30 +0100	[thread overview]
Message-ID: <Z75Qtutd68GHi2PX@calendula> (raw)
In-Reply-To: <20250225203400.28709-1-fw@strlen.de>

On Tue, Feb 25, 2025 at 09:33:57PM +0100, Florian Westphal wrote:
>  if (dep->left->payload.base != PROTO_BASE_TRANSPORT_HDR)
> 
> is legal only after checking that ->left points to an
> EXPR_PAYLOAD expression. The dependency store can also contain
> EXPR_META, in this case we access a bogus part of the union.
> 
> The payload_may_dependency_kill_icmp helper can't handle a META
> dep either, so return early.

Fixes: 533565244d88 ("payload: check icmp dependency before removing previous icmp expression")

> Signed-off-by: Florian Westphal <fw@strlen.de>

Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>

Thanks.

      reply	other threads:[~2025-02-25 23:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 20:33 [PATCH nft] payload: return early if dependency is not a payload expression Florian Westphal
2025-02-25 23:22 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z75Qtutd68GHi2PX@calendula \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.