Re: [PATCH 1/2] ucsi_ccg: Don't show failed to get FW build information error

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Thu, Feb 20, 2025 at 11:40:03PM -0600, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> The error `failed to get FW build information` is added for what looks
> to be for misdetection of the device property firmware-name.
> 
> If the property is missing (such as on non-nvidia HW) this error shows up.
> Move the error into the scope of the property parser for "firmware-name"
> to avoid showing errors on systems without the firmware-name property.
> 
> Fixes: 5c9ae5a87573d ("usb: typec: ucsi: ccg: add firmware flashing support")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 740171f24ef9f..663aca9421410 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1432,11 +1432,10 @@ static int ucsi_ccg_probe(struct i2c_client *client)
>  			uc->fw_build = CCG_FW_BUILD_NVIDIA_TEGRA;
>  		else if (!strcmp(fw_name, "nvidia,gpu"))
>  			uc->fw_build = CCG_FW_BUILD_NVIDIA;
> +		if (!uc->fw_build)
> +			dev_err(uc->dev, "failed to get FW build information\n");
>  	}
>  
> -	if (!uc->fw_build)
> -		dev_err(uc->dev, "failed to get FW build information\n");
> -
>  	/* reset ccg device and initialize ucsi */
>  	status = ucsi_ccg_init(uc);
>  	if (status < 0) {
> -- 
> 2.43.0

-- 
heikki