Re: [PATCH v2] tools/xl: fix channel configuration setting

["Anthony PERARD" <anthony.perard@vates.tech>]

On Tue, Feb 25, 2025 at 08:30:33AM +0100, Juergen Gross wrote:
> Channels work differently than other device types: their devid should
> be -1 initially in order to distinguish them from the primary console
> which has the devid of 0.
> 
> So when parsing the channel configuration, use
> ARRAY_EXTEND_INIT_NODEVID() in order to avoid overwriting the devid
> set by libxl_device_channel_init().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

This might want a:
    Fixes: 3a6679634766 ("libxl: set channel devid when not provided by application")

Before that, the devid set by `xl` was probably ignored. I think before,
the console devid would be taken from libxl__init_console_from_channel()
parametters, so the first devnum would be `0+1`, so never 0.

Do you agree?

In anycase:
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech