From: Frederic Weisbecker <frederic@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Breno Leitao <leitao@debian.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Joe Damato <jdamato@fastly.com>
Subject: Re: [PATCH net v2] net: Handle napi_schedule() calls from non-interrupt
Date: Wed, 26 Feb 2025 14:38:07 +0100 [thread overview]
Message-ID: <Z78ZPyYrzK5l6P6e@localhost.localdomain> (raw)
In-Reply-To: <CANn89i+3+y1br8V4BP5Gq58_1Z-guYQotOKAr9N1k519PLE7rA@mail.gmail.com>
Le Wed, Feb 26, 2025 at 02:34:39PM +0100, Eric Dumazet a écrit :
> On Wed, Feb 26, 2025 at 2:21 PM Frederic Weisbecker <frederic@kernel.org> wrote:
> >
>
> > That looks good and looks like what I did initially:
> >
> > https://lore.kernel.org/lkml/20250212174329.53793-2-frederic@kernel.org/
> >
> > Do you prefer me doing it over DEBUG_NET_WARN_ON_ONCE() or with lockdep
> > like in the link?
>
> To be clear, I have not tried this thing yet.
>
> Perhaps let your patch as is (for stable backports), and put the debug
> stuff only after some tests, in net-next.
Ok.
>
> It is very possible that napi_schedule() in the problematic cases were
> not on a fast path anyway.
That was my assumption but I must confess I don't know well this realm.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks!
next prev parent reply other threads:[~2025-02-26 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 22:17 [PATCH net v2] net: Handle napi_schedule() calls from non-interrupt Frederic Weisbecker
2025-02-26 10:31 ` Eric Dumazet
2025-02-26 13:21 ` Frederic Weisbecker
2025-02-26 13:34 ` Eric Dumazet
2025-02-26 13:38 ` Frederic Weisbecker [this message]
2025-03-05 8:52 ` Sebastian Andrzej Siewior
2025-02-27 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z78ZPyYrzK5l6P6e@localhost.localdomain \
--to=frederic@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.