From: Patrick Steinhardt <ps@pks.im>
To: Adam Dinwoodie <adam@dinwoodie.org>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] Makefile: set default goals in makefiles
Date: Mon, 17 Feb 2025 07:37:27 +0100 [thread overview]
Message-ID: <Z7LZJ0tRz3iLPgmx@pks.im> (raw)
In-Reply-To: <20250215211904.41883-1-adam@dinwoodie.org>
On Sat, Feb 15, 2025 at 09:19:03PM +0000, Adam Dinwoodie wrote:
> Explicitly set the default goal at the very top of various makefiles.
> This is already present in some makefiles, but not all of them.
>
> In particular, this corrects a regression introduced in a38edab7c8
> (Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06). That
> commit added some config files as build targets for the Documentation
> directory, and put the target configuration in a sensible place.
> Unfortunately, that sensible place was above any other build target
> definitions, meaning the default goal changed to being those
> configuration files only, rather than the HTML and man page
> documentation.
Thanks for the fix! The patch looks good to me, and I've double-checked
that preexisting "all:" targets were all converted to "all::".
Patrick
next prev parent reply other threads:[~2025-02-17 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 21:52 [PATCH] Makefile: correct default docs build target Adam Dinwoodie
2025-02-14 22:42 ` Junio C Hamano
2025-02-14 22:50 ` Junio C Hamano
2025-02-15 21:19 ` [PATCH v2] Makefile: set default goals in makefiles Adam Dinwoodie
2025-02-17 6:37 ` Patrick Steinhardt [this message]
2025-02-18 17:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7LZJ0tRz3iLPgmx@pks.im \
--to=ps@pks.im \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.