All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] stub: Remove monitor-fd.c
Date: Mon, 17 Feb 2025 20:03:15 +0800	[thread overview]
Message-ID: <Z7MlgwOe8Dnjdkff@intel.com> (raw)
In-Reply-To: <20250217104900.230122-1-iii@linux.ibm.com>

On Mon, Feb 17, 2025 at 11:48:49AM +0100, Ilya Leoshkevich wrote:
> Date: Mon, 17 Feb 2025 11:48:49 +0100
> From: Ilya Leoshkevich <iii@linux.ibm.com>
> Subject: [PATCH] stub: Remove monitor-fd.c
> X-Mailer: git-send-email 2.48.1
> 
> Both monitor-fd.c and monitor-internal.c contain a stub for
> monitor_get_fd(), which causes a duplicate symbol linker error when
> linking rust-qemu-api-integration. Use monitor-internal.c instead of
> monitor-fd.c and remove the latter.
> 
> Reported-by: Zhao Liu <zhao1.liu@intel.com>
> Suggested-by: Zhao Liu <zhao1.liu@intel.com>
> Fixes: fccb744f41c6 ("gdbstub: Try unlinking the unix socket before binding")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>  stubs/meson.build  | 2 +-
>  stubs/monitor-fd.c | 9 ---------
>  2 files changed, 1 insertion(+), 10 deletions(-)
>  delete mode 100644 stubs/monitor-fd.c

Thanks Ilya! LGTM,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



  reply	other threads:[~2025-02-17 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 10:48 [PATCH] stub: Remove monitor-fd.c Ilya Leoshkevich
2025-02-17 12:03 ` Zhao Liu [this message]
2025-02-17 13:42 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7MlgwOe8Dnjdkff@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=alex.bennee@linaro.org \
    --cc=iii@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.