From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org,
Sanket Goswami <Sanket.Goswami@amd.com>
Subject: Re: [PATCH 1/2] i2c: amd: Switch to guard(mutex)
Date: Mon, 17 Feb 2025 22:19:11 +0200 [thread overview]
Message-ID: <Z7OZvxCCnil-nerR@smile.fi.intel.com> (raw)
In-Reply-To: <20250217124709.3121848-1-Shyam-sundar.S-k@amd.com>
On Mon, Feb 17, 2025 at 06:17:08PM +0530, Shyam Sundar S K wrote:
> Instead of using the 'goto label; mutex_unlock()' pattern use
> 'guard(mutex)' which will release the mutex when it goes out of scope.
Both LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
But next time either sent them separately (seems like they are independent),
or add a cover letter explaining what the big picture behind all the patches
as a whole.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-17 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:47 [PATCH 1/2] i2c: amd: Switch to guard(mutex) Shyam Sundar S K
2025-02-17 12:47 ` [PATCH 2/2] i2c: dw: Update the master_xfer callback name Shyam Sundar S K
2025-02-17 20:19 ` Andy Shevchenko [this message]
2025-02-18 7:09 ` [PATCH 1/2] i2c: amd: Switch to guard(mutex) Shyam Sundar S K
2025-02-24 9:53 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7OZvxCCnil-nerR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.