From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Jonathan Humphreys <j-humphreys@ti.com>
Cc: Raymond Mao <raymond.mao@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Adriano Cordova <adrianox@gmail.com>,
Michal Simek <michal.simek@amd.com>, Udit Kumar <u-kumar1@ti.com>,
Simon Glass <sjg@chromium.org>, Devarsh Thakkar <devarsht@ti.com>,
Hari Nagalla <hnagalla@ti.com>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Santhosh Kumar K <s-k6@ti.com>,
Neha Malcom Francis <n-francis@ti.com>,
Daniel Schultz <d.schultz@phytec.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Aashvij Shenai <a-shenai@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Bryan Brattlof <bb@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Wadim Egorov <w.egorov@phytec.de>, Tom Rini <trini@konsulko.com>,
Robert Nelson <robertcnelson@gmail.com>,
Nishanth Menon <nm@ti.com>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Lukasz Majewski <lukma@denx.de>,
s-vadapalli@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/3] xilinx: dfu: Fill directly update_info.dfu_string
Date: Tue, 18 Feb 2025 09:43:39 +0200 [thread overview]
Message-ID: <Z7Q6K74Y4iI6sxnd@hera> (raw)
In-Reply-To: <20250213195351.3518305-2-j-humphreys@ti.com>
On Thu, Feb 13, 2025 at 01:53:49PM -0600, Jonathan Humphreys wrote:
> From: Michal Simek <michal.simek@amd.com>
>
> Directly fill update_info.dfu_string to prepare platforms to switch
> from using dfu_alt_info variable to dfu_string which contains description
> for capsule update when switch is done.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> board/xilinx/versal/board.c | 3 +++
> board/xilinx/zynq/board.c | 3 +++
> board/xilinx/zynqmp/zynqmp.c | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c
> index b4483d00ad1..2c387630a61 100644
> --- a/board/xilinx/versal/board.c
> +++ b/board/xilinx/versal/board.c
> @@ -8,6 +8,7 @@
> #include <cpu_func.h>
> #include <dfu.h>
> #include <env.h>
> +#include <efi_loader.h>
> #include <fdtdec.h>
> #include <init.h>
> #include <env_internal.h>
> @@ -438,5 +439,7 @@ void set_dfu_alt_info(char *interface, char *devstr)
>
> env_set("dfu_alt_info", buf);
> puts("DFU alt info setting: done\n");
> + update_info.dfu_string = strdup(buf);
> + debug("Capsule DFU: %s\n", update_info.dfu_string);
> }
> #endif
> diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c
> index a852d5b8ed5..bd004b86a88 100644
> --- a/board/xilinx/zynq/board.c
> +++ b/board/xilinx/zynq/board.c
> @@ -7,6 +7,7 @@
> #include <config.h>
> #include <debug_uart.h>
> #include <dfu.h>
> +#include <efi_loader.h>
> #include <init.h>
> #include <log.h>
> #include <dm/uclass.h>
> @@ -199,5 +200,7 @@ void set_dfu_alt_info(char *interface, char *devstr)
>
> env_set("dfu_alt_info", buf);
> puts("DFU alt info setting: done\n");
> + update_info.dfu_string = strdup(buf);
> + debug("Capsule DFU: %s\n", update_info.dfu_string);
> }
> #endif
> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
> index 820fb252a3f..8060d54428d 100644
> --- a/board/xilinx/zynqmp/zynqmp.c
> +++ b/board/xilinx/zynqmp/zynqmp.c
> @@ -11,6 +11,7 @@
> #include <dfu.h>
> #include <env.h>
> #include <env_internal.h>
> +#include <efi_loader.h>
> #include <init.h>
> #include <log.h>
> #include <net.h>
> @@ -734,6 +735,8 @@ void set_dfu_alt_info(char *interface, char *devstr)
>
> env_set("dfu_alt_info", buf);
> puts("DFU alt info setting: done\n");
> + update_info.dfu_string = strdup(buf);
> + debug("Capsule DFU: %s\n", update_info.dfu_string);
> }
> #endif
>
> --
> 2.34.1
>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2025-02-18 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 19:53 [PATCH v3 0/3] EFI Capsule update explicitly sets dfu_alt_info Jonathan Humphreys
2025-02-13 19:53 ` [PATCH v3 1/3] xilinx: dfu: Fill directly update_info.dfu_string Jonathan Humphreys
2025-02-14 16:52 ` Mattijs Korpershoek
2025-02-18 7:43 ` Ilias Apalodimas [this message]
2025-02-13 19:53 ` [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly Jonathan Humphreys
2025-02-14 16:54 ` Mattijs Korpershoek
2025-02-18 7:54 ` Ilias Apalodimas
2025-02-24 2:38 ` Jon Humphreys
2025-02-26 8:54 ` Ilias Apalodimas
2025-02-13 19:53 ` [PATCH v3 3/3] board: remove capsule update support in set_dfu_alt_info() Jonathan Humphreys
2025-02-18 8:10 ` Ilias Apalodimas
2025-02-17 7:04 ` [PATCH v3 0/3] EFI Capsule update explicitly sets dfu_alt_info Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7Q6K74Y4iI6sxnd@hera \
--to=ilias.apalodimas@linaro.org \
--cc=a-shenai@ti.com \
--cc=adrianox@gmail.com \
--cc=bb@ti.com \
--cc=caleb.connolly@linaro.org \
--cc=d.schultz@phytec.de \
--cc=devarsht@ti.com \
--cc=hnagalla@ti.com \
--cc=j-humphreys@ti.com \
--cc=lukma@denx.de \
--cc=m-chawdhry@ti.com \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=n-francis@ti.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=raymond.mao@linaro.org \
--cc=robertcnelson@gmail.com \
--cc=rogerq@kernel.org \
--cc=s-k6@ti.com \
--cc=s-vadapalli@ti.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=w.egorov@phytec.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.