From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16EBDC021AF for ; Tue, 18 Feb 2025 21:18:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B6A29608BB; Tue, 18 Feb 2025 21:18:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LfDA5aAdowoK; Tue, 18 Feb 2025 21:18:26 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7AAA96088D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739913506; bh=xjpibHSSEF25njImBVOUOzn2+A4jeVDzE8tXh3W2tcw=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Md7sVclrU04EbtxAtaMsTSTHjvUNsBHrRLhDOC8CNaQr7yBq4wbVpKMS1gHHOq3j8 auRXkDXKJPrAEWe5tgefTKbpCx+dpvShcaL19qGzWloZXOXEw9ercOZV+sDfxwqWuK Q8NV19FpDOllFFyujswG5zqzByt8jcJNrs8ej7EtLn4Tku2S/kvWxoqwRjGYxxyj1W Ol/WA25GTIBzAzLtMiBekwPXJ+i3M77cDVSz38rwso0CmZI1YV/ADWCJjHuD5XondC l6DZ/QolujyIr32Zraa+cHyE9xYpTQ1BeyQTGaN0sM4qZ3YAcggBSdA26zqjJVhMb9 ZgeAssoh2JV8w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 7AAA96088D; Tue, 18 Feb 2025 21:18:26 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id E4CD1C8 for ; Tue, 18 Feb 2025 21:18:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E09CD82F19 for ; Tue, 18 Feb 2025 21:18:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Vj7nMCwXC4Bs for ; Tue, 18 Feb 2025 21:18:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::f2b; helo=mail-qv1-xf2b.google.com; envelope-from=jdamato@fastly.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org D417D83412 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D417D83412 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by smtp1.osuosl.org (Postfix) with ESMTPS id D417D83412 for ; Tue, 18 Feb 2025 21:18:23 +0000 (UTC) Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6e65a00556aso48729026d6.3 for ; Tue, 18 Feb 2025 13:18:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739913502; x=1740518302; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjpibHSSEF25njImBVOUOzn2+A4jeVDzE8tXh3W2tcw=; b=P1XU8ZBy4V21/EBAiQdYcuBmUMcPITYZ84sVOJOiTaec4zuNcyphgCUhCIGFGDdUj2 kPYzRCUG9BEvvUcfwjjqSZROM05TJeuVIQBXbG87HGk/wI1LCwqm5ADXeqiGfKxtvCCr THlJCyAVAon32o8J3+5tYVW88pGrCaz2igdT07n5S5DShCoEgfRtb8A70d8xfNYPZqJn HGv8qz+IjJdoNqRK4LmlRxXXgNRqA4xGIbLAhaEBiwxZV1XR6o+iwWUF8smbJ28tTV4q vbMba5N5sAqFzChoV8+smEECLxeb895OObEsc7qksi7fUBqEtyWDuWip5CUqBNV+rAx0 nIGg== X-Forwarded-Encrypted: i=1; AJvYcCUF0taBrsVnRhOM1rAj2Jr4fDYqnE81/zUlJyi+NdEnMaZxkrRkxfGwcqssX3L166rgmSQHx1/1Gz4nR1Pngh4=@lists.osuosl.org X-Gm-Message-State: AOJu0Yy+sSUaYDaTv0+Ild1ivE6M/RVD4ArngD+VtGLGw68lNhQ1N8B9 mgWzAJuiUHEwOhBSzHPck5H2h4EgvDjNKtDVch9ZLeCo0PYUnWQepfkJARaLGf4= X-Gm-Gg: ASbGnctiVq5W6fMVw4uh96xyNpIfiUxmkdsB3Uej+Ljntsxf5VjcGAIXC23NE9gwPEX zqyavJ9Ej4LYoFfJvcl/3e9Rixuwb9PoTGKp8+cU5BOe1LwzRqBK2FD9XNDJEhk23CFceuLCvPi KOLNN80xDlxsoLA1ofE/NbZcEg4BO6rK6TEl97p6eD2OMgDFD4lot53X3U8iXrvLtroV3xuLCD0 Cl3C84cRji7BWyChBEN51iW++oJmwR1Mp0gr5nTRtzcLRED1wVCH3n2HaLKE4qMaM8ZlOjNJx2a 6U9aIB6c2LQQ6Piq+pappobX1didp/PN0nbOHiWHPzB3BTZyn+1jpQ== X-Google-Smtp-Source: AGHT+IHyAAERxgU6r6geBpJiRax2TCr1qrKBraw11cLisgh07q3oJukBoKVG3mWeGYHnZ0V+R+hI3Q== X-Received: by 2002:a05:6214:dc5:b0:6d4:19a0:202 with SMTP id 6a1803df08f44-6e66cd19fedmr226120986d6.33.1739913502598; Tue, 18 Feb 2025 13:18:22 -0800 (PST) Received: from LQ3V64L9R2 (ool-44c5a22e.dyn.optonline.net. [68.197.162.46]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-471ef0a5943sm27784491cf.51.2025.02.18.13.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 13:18:21 -0800 (PST) Date: Tue, 18 Feb 2025 16:18:19 -0500 From: Joe Damato To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Message-ID: Mail-Followup-To: Joe Damato , Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739913502; x=1740518302; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=xjpibHSSEF25njImBVOUOzn2+A4jeVDzE8tXh3W2tcw=; b=NQBhzNnkIz5aIoZFcCTOHwNV+zmjwLoK1jjtWuQuJJy6ddTPvVBqU706fxI7tDHdZD JSCcrIzXnEqpoB2rp4lo+mQPHERLunxNiG206uPerRpiAwaFnRpaNqeqqd5DU0V8PzWJ 8Itshap/5Qw9pO2uVB+4c6VL2rjIxS+fZOYaY= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=fastly.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=fastly.com header.i=@fastly.com header.a=rsa-sha256 header.s=google header.b=NQBhzNnk Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: > This is a follow up for the igb XDP/ZC implementation. The first two > patches link the IRQs and queues to NAPI instances. This is required to > bring back the XDP/ZC busy polling support. The last patch removes > undesired IRQs (injected via igb watchdog) while busy polling with > napi_defer_hard_irqs and gro_flush_timeout set. > > Signed-off-by: Kurt Kanzenbach > --- > Changes in v2: > - Take RTNL lock in PCI error handlers (Joe) > - Fix typo in commit message (Gerhard) > - Use netif_napi_add_config() (Joe) > - Link to v1: https://lore.kernel.org/r/20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de Thanks for sending a v2. My comment from the previous series still stands, which simply that I have no idea if the maintainers will accept changes using this API or prefer to wait until Stanislav's work [1] is completed to remove the RTNL requirement from this API altogether. [1]: https://lore.kernel.org/netdev/20250218020948.160643-1-sdf@fomichev.me/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5581286294 for ; Tue, 18 Feb 2025 21:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739913505; cv=none; b=Z3BOVVqeN/gXuVlp1vowrwMlswxyd3ALHt1pVB9T1ej6fgZbvUqNXpql4EkMZsIOAxLPDxcDFSoxAGA6dk3nJmm19uzAaghoCKH/Djpf+OBzJ8cDrw5UlvNexkP577flBNUvDPOFYrtQl1IOUUOoE+6sD6tF6UvJBqpoHZxJ0HI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739913505; c=relaxed/simple; bh=lo1Gwb2dLxkXOcXCkLAtPT8W43cAM+6sIfU2T5W7J0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uxL3JvW/iFvPS4KBebh/z9cWMx/N8oN/NoSTlheHeUCIZyS/eSCHb3l2s2jtP3kV2oAyRmOUgmQetZMVex/l8jQzclBa9sb5CpYBIz9GkgemazyTUGZnYLi2kppQnnJ7q0UCTMInygGNtpfAeXkK8KXl5PsFz4JMKjTUvAuD9Zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=JplNbAPi; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="JplNbAPi" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7c07838973eso572179785a.2 for ; Tue, 18 Feb 2025 13:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739913502; x=1740518302; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=xjpibHSSEF25njImBVOUOzn2+A4jeVDzE8tXh3W2tcw=; b=JplNbAPi99KDDt/Rjy0iZintZf+dTC2U41JEEkmydMImjUHCpzi1hBWyz+Yi+j2w7C c4WRF00WTQNqm36CDIUCQShRt3KJ/hsnx9My8Vu+KSEezu5W9vzsFsn1xqcgQSphQKCU ouJA0QjrSEw67uCKzGd2xLro0CYg9P2SdFmKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739913502; x=1740518302; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjpibHSSEF25njImBVOUOzn2+A4jeVDzE8tXh3W2tcw=; b=iOaYJRfyzRO041z8A5iO4+Ycn+0f6gczPEZGM1mNbYIPgtHA4m+rEzl4tBEtxnaqi2 63C/Y9VqMInk472VJliHl6AUJW3yfXc1Aeig1LXwDsE0zjxyfcXH+Ico+QXQVhpU/F3b Ez/JEO9ljSEeOoT9MCVTwOXlj2R+cRI4e2vyJmZiLlNyyS1VkJA576OKosxcRgw+GjDx 9/JYCc+XGy0MQT6uUjGONBZ2mntbk7M7KuB2HHHl83jpAi6+29Zf6c1ErERUDoWepglF 1i3V+IYmJfQhcL+xx+Gf8X2zCdoGIJGzVe/ckICu2uSVVqCso4Ht+tIPXkLlTqfXUEeX VDSg== X-Forwarded-Encrypted: i=1; AJvYcCXzj8KcqqDWQc6eeI3fDTUjlENMhT94ElDcx4gMR6Nvv4s8jH8toYCAD1d4Z3bWTd+FhYHT1t0=@vger.kernel.org X-Gm-Message-State: AOJu0YyTZPZsrRb2HsRCVIhoHeGkJfs57wXPAnmjjyhkmBIdbM3KDm8m 2UHgK274+iCwWkYQ1EzbT+911C8zy3TMv7+ZWPhz9yvvyGCWmPXZOR6ji48RkMA= X-Gm-Gg: ASbGnctwsIo3hfeghU31i3XygFIwIdqdSXdt7ZBkZ5r5F5KDpz/IbX635IUNhpvgnQU 3ya01uouIGbO9BP90i2TewhTirfBEm7awm4MQ6Krs+k0aesdMnUi1TRG9Hnc38azphKts4bj7uf ZoND0EKjV8snJBuNPgtybZ5VIWu1iHW+BiUZ3Tyqm4Jf1ydFfqQTkx9MsFnBpMGmGx+xMRLzgV5 0aRfNv2XBrN0k7eGG3cC/zaJssO/CRHHzXd6obg3WmZBHpVGjlag8n4uDDUc9Yr8O0GlBoSdcKG NLa9sP+oI+yUs3yxM2/wUVvIHfWUO8MX+VZXm3SXjstRJE7/6Dnbyw== X-Google-Smtp-Source: AGHT+IHyAAERxgU6r6geBpJiRax2TCr1qrKBraw11cLisgh07q3oJukBoKVG3mWeGYHnZ0V+R+hI3Q== X-Received: by 2002:a05:6214:dc5:b0:6d4:19a0:202 with SMTP id 6a1803df08f44-6e66cd19fedmr226120986d6.33.1739913502598; Tue, 18 Feb 2025 13:18:22 -0800 (PST) Received: from LQ3V64L9R2 (ool-44c5a22e.dyn.optonline.net. [68.197.162.46]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-471ef0a5943sm27784491cf.51.2025.02.18.13.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 13:18:21 -0800 (PST) Date: Tue, 18 Feb 2025 16:18:19 -0500 From: Joe Damato To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Message-ID: Mail-Followup-To: Joe Damato , Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: > This is a follow up for the igb XDP/ZC implementation. The first two > patches link the IRQs and queues to NAPI instances. This is required to > bring back the XDP/ZC busy polling support. The last patch removes > undesired IRQs (injected via igb watchdog) while busy polling with > napi_defer_hard_irqs and gro_flush_timeout set. > > Signed-off-by: Kurt Kanzenbach > --- > Changes in v2: > - Take RTNL lock in PCI error handlers (Joe) > - Fix typo in commit message (Gerhard) > - Use netif_napi_add_config() (Joe) > - Link to v1: https://lore.kernel.org/r/20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de Thanks for sending a v2. My comment from the previous series still stands, which simply that I have no idea if the maintainers will accept changes using this API or prefer to wait until Stanislav's work [1] is completed to remove the RTNL requirement from this API altogether. [1]: https://lore.kernel.org/netdev/20250218020948.160643-1-sdf@fomichev.me/