All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Dave Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	Russ Weight <russ.weight@linux.dev>
Subject: Re: [PATCH] drm/nouveau: select FW caching
Date: Tue, 18 Feb 2025 18:24:43 +0100	[thread overview]
Message-ID: <Z7TCWzTVQeEDt0j8@cassiopeiae> (raw)
In-Reply-To: <Z7SZJXP4APNLNqh2@bombadil.infradead.org>

On Tue, Feb 18, 2025 at 06:28:53AM -0800, Luis Chamberlain wrote:
> 
> What I recommend is to look into why we disable it by default, I think

I think FW_CACHE is enabled by default, no?

> its sold old obscure reasoning but now suspect it was udev being dumb,
> in line with why we also try to defensively try to ignore duplicate
> udev requests for module requests causing a flood. Refer to commit
> 9b9879fc03275ff ("modules: catch concurrent module loads, treat them as
> idempotent") for details.

Thanks, that helps a lot.

Given that this commit landed in v6.5 I guess there's not really a concern to
force enable FW_CACHE for Nouveau as a fix for commit 176fdcbddfd2
("drm/nouveau/gsp/r535: add support for booting GSP-RM"), which landed in v6.7.

  reply	other threads:[~2025-02-18 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07  1:25 [PATCH] drm/nouveau: select FW caching Dave Airlie
2025-02-14 13:05 ` Danilo Krummrich
2025-02-14 13:10   ` Danilo Krummrich
2025-02-18 14:28     ` Luis Chamberlain
2025-02-18 17:24       ` Danilo Krummrich [this message]
2025-02-18 21:39         ` Luis Chamberlain
2025-02-19  1:52           ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7TCWzTVQeEDt0j8@cassiopeiae \
    --to=dakr@kernel.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mcgrof@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=russ.weight@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.