From: Nicolin Chen <nicolinc@nvidia.com>
To: "Matthew R. Ochs" <mochs@nvidia.com>
Cc: <qemu-devel@nongnu.org>, <peter.maydell@linaro.org>,
<eric.auger@redhat.com>, <nathanc@nvidia.com>,
<qemu-arm@nongnu.org>, <shameerali.kolothum.thodi@huawei.com>,
<ddutile@redhat.com>, <ankita@nvidia.com>, <philmd@linaro.org>,
<gshan@redhat.com>
Subject: Re: [PATCH v5] hw/arm/virt: Support larger highmem MMIO regions
Date: Tue, 18 Feb 2025 11:21:26 -0800 [thread overview]
Message-ID: <Z7TdtjCd9dBNesJK@nvidia.com> (raw)
In-Reply-To: <20250218190240.3070040-1-mochs@nvidia.com>
On Tue, Feb 18, 2025 at 11:02:40AM -0800, Matthew R. Ochs wrote:
> +static void virt_get_highmem_mmio_size(Object *obj, Visitor *v, const char *name,
> + void *opaque, Error **errp)
Just some coding style nit:
static void virt_get_highmem_mmio_size(Object *obj, Visitor *v,
const char *name, void *opaque,
Error **errp)
> +static void virt_set_highmem_mmio_size(Object *obj, Visitor *v, const char *name,
> + void *opaque, Error **errp)
Ditto.
Otherwise,
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
prev parent reply other threads:[~2025-02-18 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 19:02 [PATCH v5] hw/arm/virt: Support larger highmem MMIO regions Matthew R. Ochs
2025-02-18 19:21 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7TdtjCd9dBNesJK@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=ankita@nvidia.com \
--cc=ddutile@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=mochs@nvidia.com \
--cc=nathanc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.