All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: hongxu.jia@eng.windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH V2 1/3] nerdctl: fix do_compile failed
Date: Tue, 18 Feb 2025 19:35:40 +0000	[thread overview]
Message-ID: <Z7ThDBdZYfJFCRUv@gmail.com> (raw)
In-Reply-To: <20250210074700.1751058-1-hongxu.jia@windriver.com>


I'm not quite ready to remove support for all 32bit arches, so
this is now staged on master-next.

Bruce

In message: [meta-virtualization][PATCH V2 1/3] nerdctl: fix do_compile failed
on 10/02/2025 hongxu via lists.yoctoproject.org wrote:

> Using latest poky + meta-virtualization + meta-openembedded, build multlib failed
> 
> ...local.conf...
> MACHINE = "qemux86-64"
> require conf/multilib.conf
> MULTILIBS = "multilib:lib32"
> DEFAULTTUNE:virtclass-multilib-lib32 = "x86"
> 
> $ bitbake lib32-nerdctl
> ...
> -buildmode=pie requires external (cgo) linking, but cgo is not enabled
> make: *** [Makefile:63: nerdctl] Error 1
> ...
> 
> Get back the patch to allow external specification of build settings and rebase to v2.0.2
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  ...xternal-specification-of-build-setti.patch | 28 +++++++++++--------
>  recipes-containers/nerdctl/nerdctl_git.bb     |  1 +
>  2 files changed, 18 insertions(+), 11 deletions(-)
> 
> diff --git a/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch b/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> index ca7b3042..cf7037f3 100644
> --- a/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> +++ b/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> @@ -6,20 +6,26 @@ Subject: [PATCH] Makefile: allow external specification of build settings
>  Upstream-Status: Inappropriate [embedded specific]
>  
>  Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> +
> +Rebase to v2.0.2
> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>  ---
> - Makefile | 3 ++-
> - 1 file changed, 2 insertions(+), 1 deletion(-)
> + src/import/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
>  
> -Index: nerdctl-v2.0.0-beta.1/src/import/Makefile
> -===================================================================
> ---- nerdctl-v2.0.0-beta.1.orig/src/import/Makefile
> -+++ nerdctl-v2.0.0-beta.1/src/import/Makefile
> -@@ -38,7 +38,7 @@
> +diff --git a/src/import/Makefile b/src/import/Makefile
> +index ae4e18c..eb22f9f 100644
> +--- a/src/import/Makefile
> ++++ b/src/import/Makefile
> +@@ -45,7 +45,7 @@ endif
>   
>   GO_BUILD_LDFLAGS ?= -s -w
>   GO_BUILD_FLAGS ?=
> --export GO_BUILD=GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) $(GO) build -ldflags "$(GO_BUILD_LDFLAGS) -X $(PACKAGE)/pkg/version.Version=$(VERSION) -X $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> -+export GO_BUILD=$(GO) build -ldflags "$(GO_BUILD_LDFLAGS) -X $(PACKAGE)/pkg/version.Version=$(VERSION) -X $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> +-export GO_BUILD=CGO_ENABLED=0 GOOS=$(GOOS) $(GO) -C $(MAKEFILE_DIR) build -ldflags "$(GO_BUILD_LDFLAGS) $(VERBOSE_FLAG) -X $(PACKAGE)/pkg/version.Version=$(VERSION) -X $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> ++export GO_BUILD=GOOS=$(GOOS) $(GO) -C $(MAKEFILE_DIR) build -ldflags "$(GO_BUILD_LDFLAGS) $(VERBOSE_FLAG) -X $(PACKAGE)/pkg/version.Version=$(VERSION) -X $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> + 
> + recursive_wildcard=$(wildcard $1$2) $(foreach e,$(wildcard $1*),$(call recursive_wildcard,$e/,$2))
>   
> - ifdef VERBOSE
> - 	VERBOSE_FLAG := -v
> +-- 
> +2.34.1
> +
> diff --git a/recipes-containers/nerdctl/nerdctl_git.bb b/recipes-containers/nerdctl/nerdctl_git.bb
> index 63b96846..84734c9f 100644
> --- a/recipes-containers/nerdctl/nerdctl_git.bb
> +++ b/recipes-containers/nerdctl/nerdctl_git.bb
> @@ -19,6 +19,7 @@ include src_uri.inc
>  
>  # patches and config
>  SRC_URI += " \
> +            file://0001-Makefile-allow-external-specification-of-build-setti.patch \
>              file://modules.txt \
>             "
>  
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9131): https://lists.yoctoproject.org/g/meta-virtualization/message/9131
> Mute This Topic: https://lists.yoctoproject.org/mt/111098600/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      parent reply	other threads:[~2025-02-18 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  7:46 [meta-virtualization][PATCH V2 1/3] nerdctl: fix do_compile failed Hongxu Jia
2025-02-10  7:46 ` [meta-virtualization][PATCH V2 2/3] libvirt: add json-c for driver_qemu Hongxu Jia
2025-02-10  7:47 ` [meta-virtualization][PATCH V2 3/3] libvirt: fix installed-vs-shipped QA error Hongxu Jia
2025-02-10 18:30 ` [meta-virtualization][PATCH V2 1/3] nerdctl: fix do_compile failed Bruce Ashfield
2025-02-12  2:14   ` Hongxu Jia
2025-02-18 19:35 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7ThDBdZYfJFCRUv@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=hongxu.jia@eng.windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.