From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Saeed Mahameed <saeed@kernel.org>
Subject: Re: [PATCH net-next v4 11/12] docs: net: document new locking reality
Date: Tue, 18 Feb 2025 20:52:07 -0800 [thread overview]
Message-ID: <Z7Vjd7Xx1wplacKC@mini-arch> (raw)
In-Reply-To: <20250218185323.70f61e4f@kernel.org>
On 02/18, Jakub Kicinski wrote:
> On Mon, 17 Feb 2025 18:09:47 -0800 Stanislav Fomichev wrote:
> > +RTNL and netdev instance lock
> > +=============================
> > +
> > +Historically, all networking control operations were protected by a single
> > +global lock known as RTNL. There is an ongoing effort to replace this global
>
> I think RTNL stands for RouTeNetLink. RTNL -> rtnl_lock here?
SG. Will do s/RTNL/rtnl_lock/ in a bunch of other (new) places.
> > +lock with separate locks for each network namespace. The netdev instance lock
> > +represents another step towards making the locking mechanism more granular.
>
> Reads a bit like the per-netns and instance locks are related.
> Maybe rephrase as:
>
> lock with separate locks for each network namespace. Additionally, properties
> of individual netdev are increasingly protected by per-netdev locks.
Sure.
> > +For device drivers that implement shaping or queue management APIs, all control
> > +operations will be performed under the netdev instance lock. Currently, this
> > +instance lock is acquired within the context of RTNL. In the future, there will
> > +be an option for individual drivers to opt out of using RTNL and instead
> > +perform their control operations directly under the netdev instance lock.
> > +
> > +Devices drivers are encouraged to rely on the instance lock where possible.
next prev parent reply other threads:[~2025-02-19 4:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 2:09 [PATCH net-next v4 00/12] net: Hold netdev instance lock during ndo operations Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 01/12] net: hold netdev instance lock during ndo_open/ndo_stop Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 02/12] net: hold netdev instance lock during ndo_setup_tc Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 03/12] net: hold netdev instance lock during queue operations Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 04/12] net: hold netdev instance lock during rtnetlink operations Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 05/12] net: hold netdev instance lock during ioctl operations Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 06/12] net: hold netdev instance lock during sysfs operations Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 07/12] net: hold netdev instance lock during ndo_bpf Stanislav Fomichev
2025-02-19 3:02 ` Jakub Kicinski
2025-02-19 4:54 ` Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 08/12] net: ethtool: try to protect all callback with netdev instance lock Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 09/12] net: replace dev_addr_sem " Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 10/12] net: dummy: add dummy shaper API Stanislav Fomichev
2025-02-19 3:09 ` Jakub Kicinski
2025-02-19 4:56 ` Stanislav Fomichev
2025-02-19 17:36 ` Jakub Kicinski
2025-02-18 2:09 ` [PATCH net-next v4 11/12] docs: net: document new locking reality Stanislav Fomichev
2025-02-19 2:53 ` Jakub Kicinski
2025-02-19 4:52 ` Stanislav Fomichev [this message]
2025-02-19 8:37 ` Paolo Abeni
2025-02-19 15:43 ` Stanislav Fomichev
2025-02-18 2:09 ` [PATCH net-next v4 12/12] eth: bnxt: remove most dependencies on RTNL Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7Vjd7Xx1wplacKC@mini-arch \
--to=stfomichev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.