From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next v2 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988
Date: Wed, 19 Feb 2025 09:33:44 +0000 [thread overview]
Message-ID: <Z7WleP9v6Igx2MjC@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250219083910.2255981-4-SkyLake.Huang@mediatek.com>
On Wed, Feb 19, 2025 at 04:39:10PM +0800, Sky Huang wrote:
> +static int mt798x_2p5ge_phy_config_init(struct phy_device *phydev)
> +{
> + struct pinctrl *pinctrl;
> + int ret;
> +
> + /* Check if PHY interface type is compatible */
> + if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> + return -ENODEV;
> +
> + ret = mt798x_2p5ge_phy_load_fw(phydev);
> + if (ret < 0)
> + return ret;
Firmware should not be loaded in the .config_init method. The above
call will block while holding the RTNL which will prevent all other
network configuration until the firmware has been loaded or the load
fails.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-19 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 8:39 [PATCH net-next v2 0/2] Add 2.5G ethernet phy support on MT7988 Sky Huang
2025-02-19 8:39 ` [PATCH net-next v2 1/3] net: phy: mediatek: Add 2.5Gphy firmware dt-bindings and dts node Sky Huang
2025-02-19 12:26 ` Krzysztof Kozlowski
2025-02-19 15:26 ` Andrew Lunn
2025-02-19 15:30 ` Daniel Golle
2025-02-25 10:59 ` SkyLake Huang (黃啟澤)
2025-02-25 13:51 ` Andrew Lunn
2025-02-26 4:14 ` SkyLake Huang (黃啟澤)
2025-02-26 13:26 ` Andrew Lunn
2025-05-13 9:45 ` SkyLake Huang (黃啟澤)
2025-02-19 8:39 ` [PATCH net-next v2 2/3] dts: mt7988a: Add built-in ethernet phy firmware node Sky Huang
2025-02-19 12:28 ` Krzysztof Kozlowski
2025-02-19 8:39 ` [PATCH net-next v2 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2025-02-19 9:33 ` Russell King (Oracle) [this message]
2025-02-19 15:16 ` Andrew Lunn
2025-02-26 6:48 ` SkyLake Huang (黃啟澤)
2025-02-26 9:52 ` Russell King (Oracle)
2025-05-13 11:13 ` SkyLake Huang (黃啟澤)
2025-02-26 13:32 ` Andrew Lunn
2025-05-13 11:15 ` SkyLake Huang (黃啟澤)
2025-05-13 10:12 ` SkyLake Huang (黃啟澤)
2025-05-13 11:01 ` SkyLake Huang (黃啟澤)
2025-05-13 12:32 ` Andrew Lunn
2025-02-19 15:47 ` Andrew Lunn
2025-05-13 10:55 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7WleP9v6Igx2MjC@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.