From: Namhyung Kim <namhyung@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Stephen Brennan <stephen.s.brennan@oracle.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Chaitanya S Prakash <chaitanyas.prakash@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 1/1] tools: perf: support .gnu_debugdata for symbols
Date: Wed, 19 Feb 2025 13:15:45 -0800 [thread overview]
Message-ID: <Z7ZKAYutejOOoBbQ@google.com> (raw)
In-Reply-To: <871pw0gw8d.fsf@linux.intel.com>
Hello,
On Fri, Feb 14, 2025 at 11:30:26AM -0800, Andi Kleen wrote:
> Stephen Brennan <stephen.s.brennan@oracle.com> writes:
> > DSO_BINARY_TYPE__GUEST_KMODULE_COMP,
> > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> > index 66fd1249660a3..e578b7d406a69 100644
> > --- a/tools/perf/util/symbol-elf.c
> > +++ b/tools/perf/util/symbol-elf.c
> > @@ -6,6 +6,7 @@
> > #include <string.h>
> > #include <unistd.h>
> > #include <inttypes.h>
> > +#include <lzma.h>
>
> This needs some ifdefs in case lzma.h is not available?
Right, should be guarded by HAVE_LZMA_SUPPORT.
Thanks,
Namhyung
next prev parent reply other threads:[~2025-02-19 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 19:05 [PATCH 0/1] Support .gnu_debugdata for symbols in perf Stephen Brennan
2025-02-13 19:05 ` [PATCH 1/1] tools: perf: support .gnu_debugdata for symbols Stephen Brennan
2025-02-14 19:30 ` Andi Kleen
2025-02-19 21:15 ` Namhyung Kim [this message]
2025-02-19 21:57 ` Stephen Brennan
2025-02-19 22:14 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7ZKAYutejOOoBbQ@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chaitanyas.prakash@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.