From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Daniel Gomez <da.gomez@kernel.org>,
Paul Bunyan <pbunyan@redhat.com>, Yi Zhang <yi.zhang@redhat.com>,
Luis Chamberlain <mcgrof@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Keith Busch <kbusch@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V4] block: make segment size limit workable for > 4K PAGE_SIZE
Date: Wed, 19 Feb 2025 22:13:24 -0800 [thread overview]
Message-ID: <Z7bIBNc1SuTyy6ac@infradead.org> (raw)
In-Reply-To: <20250219024409.901186-1-ming.lei@redhat.com>
On Wed, Feb 19, 2025 at 10:44:09AM +0800, Ming Lei wrote:
> PAGE_SIZE is applied in validating block device queue limits, this way is
> very fragile and is wrong:
It's neither very fragily nor wrong. If you want to change it to suit
your needs that might or might not be ok but this language isn't.
> - queue limits are read from hardware, which is often one readonly hardware
> property
queues limits aren't read from hardware per definition. Very often they
are software limits.
next prev parent reply other threads:[~2025-02-20 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 2:44 [PATCH V4] block: make segment size limit workable for > 4K PAGE_SIZE Ming Lei
2025-02-20 6:13 ` Christoph Hellwig [this message]
2025-02-20 11:38 ` Ming Lei
2025-02-21 20:12 ` Luis Chamberlain
2025-02-22 21:43 ` Daniel Gomez
2025-02-24 0:55 ` Luis Chamberlain
2025-02-24 1:48 ` Ming Lei
2025-02-22 21:52 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7bIBNc1SuTyy6ac@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=da.gomez@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=pbunyan@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.