From: Peter Xu <peterx@redhat.com>
To: Juraj Marcin <jmarcin@redhat.com>
Cc: Fabiano Rosas <farosas@suse.de>,
qemu-devel@nongnu.org, Yan Fu <yafu@redhat.com>
Subject: Re: [PATCH] migration: Fix UAF for incoming migration on MigrationState
Date: Thu, 20 Feb 2025 10:33:36 -0500 [thread overview]
Message-ID: <Z7dLUCdhRyby3Tp9@x1.local> (raw)
In-Reply-To: <gtxeejfyyr4v7ebwtesl6zn743knf4bp73balfmlhlgxm3a5jw@kqig7553jjen>
On Thu, Feb 20, 2025 at 03:48:17PM +0100, Juraj Marcin wrote:
> Maybe it could be also useful to add assertions to places where locked
> BQL is assumed and the assumption is not clear enough. Then, when
> something changes, it will fail with a clear reason instead of debugging
> race conditions that might occur.
Right. We have plenty of those already:
$ git grep "assert(bql_locked())" | wc -l
If there's some places that we find that is not clear on BQL dependency but
relies on that, we can consider adding more if that helps clarifications.
--
Peter Xu
next prev parent reply other threads:[~2025-02-20 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 13:24 [PATCH] migration: Fix UAF for incoming migration on MigrationState Peter Xu
2025-02-20 14:06 ` Fabiano Rosas
2025-02-20 14:48 ` Juraj Marcin
2025-02-20 15:33 ` Peter Xu [this message]
2025-02-20 15:29 ` Peter Xu
2025-02-20 15:56 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7dLUCdhRyby3Tp9@x1.local \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yafu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.