From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
dxu@dxuuu.xyz, michael.chan@broadcom.com, ap420073@gmail.com
Subject: Re: [PATCH net v2 1/2] net: ethtool: fix ioctl confusing drivers about desired HDS user config
Date: Fri, 21 Feb 2025 08:07:18 -0800 [thread overview]
Message-ID: <Z7ikttkCnaW_rajB@mini-arch> (raw)
In-Reply-To: <20250221025141.1132944-1-kuba@kernel.org>
On 02/20, Jakub Kicinski wrote:
> The legacy ioctl path does not have support for extended attributes.
> So we issue a GET to fetch the current settings from the driver,
> in an attempt to keep them unchanged. HDS is a bit "special" as
> the GET only returns on/off while the SET takes a "ternary" argument
> (on/off/default). If the driver was in the "default" setting -
> executing the ioctl path binds it to on or off, even tho the user
> did not intend to change HDS config.
>
> Factor the relevant logic out of the netlink code and reuse it.
>
> Fixes: 87c8f8496a05 ("bnxt_en: add support for tcp-data-split ethtool command")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
next prev parent reply other threads:[~2025-02-21 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 2:51 [PATCH net v2 1/2] net: ethtool: fix ioctl confusing drivers about desired HDS user config Jakub Kicinski
2025-02-21 2:51 ` [PATCH net v2 2/2] selftests: drv-net: test XDP, HDS auto and the ioctl path Jakub Kicinski
2025-02-21 16:07 ` Stanislav Fomichev
2025-02-23 12:32 ` Taehee Yoo
2025-02-21 16:07 ` Stanislav Fomichev [this message]
2025-02-23 1:17 ` [PATCH net v2 1/2] net: ethtool: fix ioctl confusing drivers about desired HDS user config Daniel Xu
2025-02-23 12:26 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7ikttkCnaW_rajB@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.