From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>,
arnd@arndb.de, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] io.h: drop unused headers
Date: Fri, 21 Feb 2025 18:10:56 +0200 [thread overview]
Message-ID: <Z7ilkKt1waKJuZPi@smile.fi.intel.com> (raw)
In-Reply-To: <202502211137.IRE8qrlR-lkp@intel.com>
On Fri, Feb 21, 2025 at 11:22:38AM +0800, kernel test robot wrote:
> Hi Raag,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
> base: b16e9f8547a328b19af59afc213ce323124d11e9
> patch link: https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
> patch subject: [PATCH v1] io.h: drop unused headers
> config: nios2-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502211137.IRE8qrlR-lkp@intel.com/
...
> drivers/gpu/drm/drm_draw.c: At top level:
> >> drivers/gpu/drm/drm_draw.c:134:1: warning: data definition has no type or storage class
> 134 | EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
> | ^~~~~~~~~~~~~
> >> drivers/gpu/drm/drm_draw.c:134:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> >> drivers/gpu/drm/drm_draw.c:134:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
> drivers/gpu/drm/drm_draw.c:151:1: warning: data definition has no type or storage class
> 151 | EXPORT_SYMBOL(drm_draw_blit16);
> | ^~~~~~~~~~~~~
I haven't looked deeply into this, but it might be the export.h is missing
or it's just a followup of missing bug.h. In any case the io.h patch needs
a prerequisite for dwm_draw.c to eliminate usage of "proxy" headers and follow
IWYU principle. So, it will become a series of two. But as I said before,
let's wait a bit longer.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-21 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 17:33 [PATCH v1] io.h: drop unused headers Raag Jadav
2025-02-21 2:52 ` kernel test robot
2025-02-21 16:07 ` Andy Shevchenko
2025-02-21 3:22 ` kernel test robot
2025-02-21 16:10 ` Andy Shevchenko [this message]
2025-02-21 16:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7ilkKt1waKJuZPi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.