All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Kamila Sionek <kamila.sionek@adtran.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: Backporting patches to resolve rsa-caam self-test issues in kernel 5.10.231
Date: Fri, 21 Feb 2025 15:08:55 -0500	[thread overview]
Message-ID: <Z7jdVzOM1rcQzM60@lappy> (raw)
In-Reply-To: <BEZP281MB3029E2F4767A20F1571F7E0B81C42@BEZP281MB3029.DEUP281.PROD.OUTLOOK.COM>

Hi Kamila,

On Thu, Feb 20, 2025 at 02:02:03PM +0000, Kamila Sionek wrote:
>Dear Maintainers,
>
>I would like to bring to your attention the need for a backport of several patches to the 5.10.X kernel to address issues with self-tests for rsa-caam. In kernel version 5.10.231-rt123, the introduction of commit dead96e1c748ff84ecac83ea3c5a4d7a2e57e051 (crypto: caam - add error check to caam_rsa_set_priv_key_form), which added checks for memory allocation errors, has caused the self-test for rsa-caam to fail in FIPS mode, resulting in the following error message:
>
>alg: akcipher: test 1 failed for rsa-caam, err=-12
>Kernel panic - not syncing:
>alg: self-tests for rsa-caam (rsa) failed in fips mode!
>
>The following patches should be backported to resolve this issue:

Thanks for the heads up, I've queued them for the next release.

One nit:

>8aaa4044999863199124991dfa489fd248d73789 (crypto: testmgr - some more fixes to RSA test vectors)
>d824c61df41758f8c045e9522e850b615ee0ca1c (crypto: testmgr - populate RSA CRT parameters in RSA test vectors)
>ceb31f1c4c6894c4f9e65f4381781917a7a4c898 (crypto: testmgr - fix version number of RSA tests)
>88c2d62e7920edb50661656c85932b5cd100069b (crypto: testmgr - Fix wrong test case of RSA)
>1040cf9c9e7518600e7fcc24764d1c4b8a1b62f5 (crypto: testmgr - fix wrong key length for pkcs1pad)

These SHA1s don't seem to correspond to a public tree, so I suspect that
you cherry-picked them locally. This made me feel better as I suspect
that you also thoroughly tested them, but keep it in mind for next time
:)

-- 
Thanks,
Sasha

      reply	other threads:[~2025-02-21 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 14:02 Backporting patches to resolve rsa-caam self-test issues in kernel 5.10.231 Kamila Sionek
2025-02-21 20:08 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7jdVzOM1rcQzM60@lappy \
    --to=sashal@kernel.org \
    --cc=kamila.sionek@adtran.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.