All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org,  Hang SU <darcy.sh@antgroup.com>
Subject: Re: [kvm-unit-tests PATCH 3/3] x86: replace segment selector magic number with macro definition
Date: Fri, 21 Feb 2025 15:34:42 -0800	[thread overview]
Message-ID: <Z7kNkpcMZfbopCMH@google.com> (raw)
In-Reply-To: <20250221225406.2228938-4-seanjc@google.com>

On Fri, Feb 21, 2025, Sean Christopherson wrote:
> @@ -15,7 +17,7 @@ sipi_entry:
>  	or $1, %eax
>  	mov %eax, %cr0
>  	lgdtl ap_rm_gdt_descr - sipi_entry
> -	ljmpl $8, $ap_start32
> +	ljmpl $KERNEL_CS32, $ap_start32

Gah, this is wrong, it should be KERNEL_CS, not KERNEL_CS32.  It was wrong in the
original posting as well.  Not sure how I missed it the first time around.

I'll fixup when applying.

  reply	other threads:[~2025-02-21 23:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 22:54 [kvm-unit-tests PATCH 0/3] x86: Use macros for selectors in asm Sean Christopherson
2025-02-21 22:54 ` [kvm-unit-tests PATCH 1/3] x86: Move descriptor table selector #defines to the top of desc.h Sean Christopherson
2025-02-21 22:54 ` [kvm-unit-tests PATCH 2/3] x86: Commit to using __ASSEMBLER__ instead of __ASSEMBLY__ Sean Christopherson
2025-02-21 22:54 ` [kvm-unit-tests PATCH 3/3] x86: replace segment selector magic number with macro definition Sean Christopherson
2025-02-21 23:34   ` Sean Christopherson [this message]
2025-02-24 17:24 ` [kvm-unit-tests PATCH 0/3] x86: Use macros for selectors in asm Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7kNkpcMZfbopCMH@google.com \
    --to=seanjc@google.com \
    --cc=darcy.sh@antgroup.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.