From: Ritvik Gupta <ritvikfoss@gmail.com>
To: Seyediman Seyedarab <imandevel@gmail.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] selftests/mount: Close 'fd' when write fails
Date: Sun, 23 Feb 2025 09:51:12 +0530 [thread overview]
Message-ID: <Z7qiOE3EXo8BtdY8@ritvikos> (raw)
In-Reply-To: <zshes4xtyir7zrrybeqj2amrxyctwqnuvx2tqyktv4vsfstxqi@pvdq2rb5m47j>
Yes, the kernel will handle the 'fd' cleanup automatically, but
the existing implementation already closes it before exiting.
However, in case where write fails, its unhandled.
This patch addresses that gap :)
Nevertheless it's subjective indeed.
Thanks for reviewing!
Regards
Ritvik
next prev parent reply other threads:[~2025-02-23 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 11:47 [PATCH] selftests/mount: Close 'fd' when write fails ritvikfoss
2025-02-22 12:12 ` [PATCH v2] " ritvikfoss
2025-02-22 19:01 ` Seyediman Seyedarab
2025-02-23 4:21 ` Ritvik Gupta [this message]
2025-02-23 7:01 ` Seyediman Seyedarab
2025-02-23 8:14 ` Ritvik Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7qiOE3EXo8BtdY8@ritvikos \
--to=ritvikfoss@gmail.com \
--cc=imandevel@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.