From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Date: Mon, 24 Feb 2025 08:22:05 +0100 [thread overview]
Message-ID: <Z7weHW5bJnYpiAEN@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250224-net-am654-nuss-kconfig-v2-1-c124f4915c92@pengutronix.de>
On Mon, Feb 24, 2025 at 06:17:16AM +0100, Sascha Hauer wrote:
> am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> selected to avoid linker errors. This is missing since the driver
> started to use page_pool helpers in 8acacc40f733 ("net: ethernet:
> ti: am65-cpsw: Add minimal XDP support")
>
> Fixes: 8acacc40f733 ("net: ethernet: ti: am65-cpsw: Add minimal XDP support")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Changes in v2:
> - Add missing Fixes: tag
> - Link to v1: https://lore.kernel.org/r/20250220-net-am654-nuss-kconfig-v1-1-acc813b769de@pengutronix.de
> ---
> drivers/net/ethernet/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 0d5a862cd78a6..3a13d60a947a8 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -99,6 +99,7 @@ config TI_K3_AM65_CPSW_NUSS
> select NET_DEVLINK
> select TI_DAVINCI_MDIO
> select PHYLINK
> + select PAGE_POOL
> select TI_K3_CPPI_DESC_POOL
> imply PHY_TI_GMII_SEL
> depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS
>
> ---
> base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
> change-id: 20250220-net-am654-nuss-kconfig-ab8e4f4e318b
>
> Best regards,
> --
> Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
next prev parent reply other threads:[~2025-02-24 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 5:17 [PATCH v2] net: ethernet: ti: am65-cpsw: select PAGE_POOL Sascha Hauer
2025-02-24 7:22 ` Michal Swiatkowski [this message]
2025-02-26 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7weHW5bJnYpiAEN@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.