All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Cc: sre@kernel.org, rdunlap@infradead.org,
	linux-kernel@vger.kernel.org, 21210240012@m.fudan.edu.cn,
	21302010073@m.fudan.edu.cn
Subject: Re: [PATCH v3] HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition
Date: Mon, 24 Feb 2025 12:59:49 +0200	[thread overview]
Message-ID: <Z7xRJbUVEcbWnCgO@smile.fi.intel.com> (raw)
In-Reply-To: <88CA06F7CB097DC8+6c5e0521.3de0.19535fad611.Coremail.kxwang23@m.fudan.edu.cn>

On Mon, Feb 24, 2025 at 11:23:06AM +0800, Kaixin Wang wrote:
> At 2024-09-18 20:07:50, "Kaixin Wang" <kxwang23@m.fudan.edu.cn> wrote:

> >In the ssi_protocol_probe() function, &ssi->work is bound with
> >ssip_xmit_work(), In ssip_pn_setup(), the ssip_pn_xmit() function
> >within the ssip_pn_ops structure is capable of starting the
> >work.
> >
> >If we remove the module which will call ssi_protocol_remove()
> >to make a cleanup, it will free ssi through kfree(ssi),
> >while the work mentioned above will be used. The sequence
> >of operations that may lead to a UAF bug is as follows:
> >
> >CPU0                                    CPU1
> >
> >                        | ssip_xmit_work
> >ssi_protocol_remove     |
> >kfree(ssi);             |
> >                        | struct hsi_client *cl = ssi->cl;
> >                        | // use ssi
> >
> >Fix it by ensuring that the work is canceled before proceeding
> >with the cleanup in ssi_protocol_remove().

...

> Hi, I noticed that there are no relevant replies to this patch that I sent
> several months ago. Is it missed?

Seems like fell into cracks...

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-02-24 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 12:07 [PATCH v3] HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition Kaixin Wang
2025-02-24  3:23 ` Kaixin Wang
2025-02-24 10:59   ` Andy Shevchenko [this message]
2025-02-25  1:08     ` [PATCH " Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7xRJbUVEcbWnCgO@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=21210240012@m.fudan.edu.cn \
    --cc=21302010073@m.fudan.edu.cn \
    --cc=kxwang23@m.fudan.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.