From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: sven@svenpeter.dev
Cc: Janne Grunau <j@jannau.net>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] soc: apple: rtkit: Add APPLE_RTKIT_PWR_STATE_INIT
Date: Mon, 24 Feb 2025 13:03:44 -0500 [thread overview]
Message-ID: <Z7y0gJPD5-OQvyog@blossom> (raw)
In-Reply-To: <20250222-apple-soc-misc-v1-1-1a3af494a48a@svenpeter.dev>
> - msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_ON);
> + msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_INIT);
Commit message doesn't match the code. Just adding the state doesn't
imply a behaviour change but the patch is one. How about "Use INIT state
instead of ON" or something to make explicit the behaviour change?
next prev parent reply other threads:[~2025-02-24 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 16:56 [PATCH 0/4] Miscellaneous Apple RTKit fixes Sven Peter via B4 Relay
2025-02-22 16:56 ` Sven Peter
2025-02-22 16:56 ` [PATCH 1/4] soc: apple: rtkit: Add APPLE_RTKIT_PWR_STATE_INIT Sven Peter via B4 Relay
2025-02-22 16:56 ` Sven Peter
2025-02-24 18:03 ` Alyssa Rosenzweig [this message]
2025-02-26 15:47 ` Sven Peter
2025-02-22 16:56 ` [PATCH 2/4] soc: apple: rtkit: Implement OSLog buffers properly Sven Peter via B4 Relay
2025-02-22 16:56 ` Sven Peter
2025-02-24 18:09 ` Alyssa Rosenzweig
2025-02-26 16:51 ` Sven Peter
2025-02-26 17:05 ` Alyssa Rosenzweig
2025-02-26 17:29 ` Sven Peter
2025-02-22 16:56 ` [PATCH 3/4] soc: apple: rtkit: Use high prio work queue Sven Peter via B4 Relay
2025-02-22 16:56 ` Sven Peter
2025-02-24 18:10 ` Alyssa Rosenzweig
2025-02-22 16:56 ` [PATCH 4/4] soc: apple: rtkit: Cut syslog messages after the first '\0' Sven Peter via B4 Relay
2025-02-22 16:56 ` Sven Peter
2025-02-24 18:10 ` Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7y0gJPD5-OQvyog@blossom \
--to=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.