From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
kernel test robot <lkp@intel.com>, Andrew Davis <afd@ti.com>
Subject: Re: [PATCH] remoteproc: omap: add comment for is_iomem
Date: Mon, 24 Feb 2025 09:22:58 -0700 [thread overview]
Message-ID: <Z7yc4vxYkTMhSWni@p14s> (raw)
In-Reply-To: <20250217075858.616737-1-peng.fan@oss.nxp.com>
On Mon, Feb 17, 2025 at 03:58:58PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Address warning: "Function parameter or struct member 'is_iomem' not
> described in 'omap_rproc_da_to_va'" with adding comment for is_iomem.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502161648.WZWrFV7I-lkp@intel.com/
> Cc: Andrew Davis <afd@ti.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/omap_remoteproc.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied - thanks,
Mathieu
> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> index 5f463937cbbf..9c7182b3b038 100644
> --- a/drivers/remoteproc/omap_remoteproc.c
> +++ b/drivers/remoteproc/omap_remoteproc.c
> @@ -724,6 +724,7 @@ static int omap_rproc_stop(struct rproc *rproc)
> * @rproc: remote processor to apply the address translation for
> * @da: device address to translate
> * @len: length of the memory buffer
> + * @is_iomem: pointer filled in to indicate if @da is iomapped memory
> *
> * Custom function implementing the rproc .da_to_va ops to provide address
> * translation (device address to kernel virtual address) for internal RAMs
> --
> 2.37.1
>
prev parent reply other threads:[~2025-02-24 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 7:58 [PATCH] remoteproc: omap: add comment for is_iomem Peng Fan (OSS)
2025-02-24 16:22 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7yc4vxYkTMhSWni@p14s \
--to=mathieu.poirier@linaro.org \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.