From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Thangaraj.S@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, Rengarajan.S@microchip.com,
Woojung.Huh@microchip.com, pabeni@redhat.com,
edumazet@google.com, kuba@kernel.org, phil@raspberrypi.org,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management
Date: Mon, 10 Mar 2025 10:11:29 +0000 [thread overview]
Message-ID: <Z8660bKssi3rX_ny@shell.armlinux.org.uk> (raw)
In-Reply-To: <Z863zsYNM8hkfB19@pengutronix.de>
On Mon, Mar 10, 2025 at 10:58:38AM +0100, Oleksij Rempel wrote:
> Hi Thangaraj,
>
> On Mon, Mar 10, 2025 at 09:29:45AM +0000, Thangaraj.S@microchip.com wrote:
> > > - mii_adv_to_linkmode_adv_t(fc, mii_adv);
> > > - linkmode_or(phydev->advertising, fc, phydev->advertising);
> > > + phy_suspend(phydev);
> > >
> >
> > Why phy_suspend called in the init? Is there any specific reason?
>
> In my tests with EVB-LAN7801-EDS, the attached PHY stayed UP in initial
> state.
Why is that an issue?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-03-10 10:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 18:24 [PATCH net-next v2 0/7] Convert LAN78xx to PHYLINK Oleksij Rempel
2025-03-07 18:24 ` [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management Oleksij Rempel
2025-03-08 13:51 ` Maxime Chevallier
2025-03-10 9:29 ` Thangaraj.S
2025-03-10 9:58 ` Oleksij Rempel
2025-03-10 10:11 ` Russell King (Oracle) [this message]
2025-03-10 10:16 ` Oleksij Rempel
2025-03-10 10:23 ` Russell King (Oracle)
2025-03-07 18:24 ` [PATCH net-next v2 2/7] net: usb: lan78xx: Move fixed PHY cleanup to lan78xx_unbind() Oleksij Rempel
2025-03-08 13:54 ` Maxime Chevallier
2025-03-07 18:24 ` [PATCH net-next v2 3/7] net: usb: lan78xx: Improve error handling for PHY init path Oleksij Rempel
2025-03-07 18:24 ` [PATCH net-next v2 4/7] net: usb: lan78xx: Use ethtool_op_get_link to reflect current link status Oleksij Rempel
2025-03-07 18:24 ` [PATCH net-next v2 5/7] net: usb: lan78xx: port link settings to phylink API Oleksij Rempel
2025-03-07 18:24 ` [PATCH net-next v2 6/7] net: usb: lan78xx: Transition get/set_pause to phylink Oleksij Rempel
2025-03-07 18:24 ` [PATCH net-next v2 7/7] net: usb: lan78xx: Integrate EEE support with phylink LPI API Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8660bKssi3rX_ny@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Rengarajan.S@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.