From: Anton Protopopov <aspsk@isovalent.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: Convert comma to semicolon
Date: Mon, 10 Mar 2025 08:09:36 +0000 [thread overview]
Message-ID: <Z86eQH1dV0zEm3Ov@mail.gmail.com> (raw)
In-Reply-To: <20250310032045.651068-1-nichen@iscas.ac.cn>
On 25/03/10 11:20AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
This is a typo, of course. Thanks!
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Anton Protopopov <aspsk@isovalent.com>
> ---
> tools/testing/selftests/bpf/prog_tests/fd_array.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/fd_array.c b/tools/testing/selftests/bpf/prog_tests/fd_array.c
> index a1d52e73fb16..9add890c2d37 100644
> --- a/tools/testing/selftests/bpf/prog_tests/fd_array.c
> +++ b/tools/testing/selftests/bpf/prog_tests/fd_array.c
> @@ -83,8 +83,8 @@ static inline int bpf_prog_get_map_ids(int prog_fd, __u32 *nr_map_ids, __u32 *ma
> int err;
>
> memset(&info, 0, len);
> - info.nr_map_ids = *nr_map_ids,
> - info.map_ids = ptr_to_u64(map_ids),
> + info.nr_map_ids = *nr_map_ids;
> + info.map_ids = ptr_to_u64(map_ids);
>
> err = bpf_prog_get_info_by_fd(prog_fd, &info, &len);
> if (!ASSERT_OK(err, "bpf_prog_get_info_by_fd"))
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-03-10 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 3:20 [PATCH] selftests/bpf: Convert comma to semicolon Chen Ni
2025-03-10 8:09 ` Anton Protopopov [this message]
2025-03-11 0:00 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2025-04-01 6:15 Chen Ni
2025-04-01 18:05 ` Amery Hung
2025-04-04 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z86eQH1dV0zEm3Ov@mail.gmail.com \
--to=aspsk@isovalent.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=nichen@iscas.ac.cn \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.