Re: [PATCH v2 3/3] qapi/machine: Make @dump-skeys command generic

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Mar 10, 2025 at 02:31:18PM +0100, Philippe Mathieu-Daudé wrote:
> Reduce misc-target.json by one target specific command.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  qapi/machine.json          | 18 ++++++++++++++++++
>  qapi/misc-target.json      | 19 -------------------
>  hw/core/machine-qmp-cmds.c | 13 +++++++++++++
>  hw/s390x/s390-skeys.c      |  6 +-----
>  4 files changed, 32 insertions(+), 24 deletions(-)
> 
> diff --git a/qapi/machine.json b/qapi/machine.json
> index a6b8795b09e..53680bf0998 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1898,3 +1898,21 @@
>  { 'command': 'x-query-interrupt-controllers',
>    'returns': 'HumanReadableText',
>    'features': [ 'unstable' ]}
> +
> +##
> +# @dump-skeys:
> +#
> +# Dump guest's storage keys
> +#
> +# @filename: the path to the file to dump to
> +#
> +# Since: 2.5
> +#
> +# .. qmp-example::
> +#
> +#     -> { "execute": "dump-skeys",
> +#          "arguments": { "filename": "/tmp/skeys" } }
> +#     <- { "return": {} }
> +##

Currently the 'if: TARGET_S390X' ends up in the documentation
so users can see it is s390x-onl:

 https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#qapidoc-2890

Given there's no more conditional, the docs will loose this target
info, which could be considered a regression. We could tweak the
docs text to call this out:

 ##
 # @dump-skeys:
 #
 # Dump the storage keys for an s390x guest
 #




With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|