All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
	andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	sander@svanheule.net, markus.stockhausen@gmx.de,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v9] net: mdio: Add RTL9300 MDIO driver
Date: Mon, 10 Mar 2025 18:15:01 +0000	[thread overview]
Message-ID: <Z88sJSzFTmYMvsZL@shell.armlinux.org.uk> (raw)
In-Reply-To: <3514933e-0fdd-4f1e-b1e4-b72a638edfc8@wanadoo.fr>

On Mon, Mar 10, 2025 at 07:06:13PM +0100, Christophe JAILLET wrote:
> > +		err = of_property_read_u32(phy_dn, "reg", &addr);
> > +		if (err)
> > +			return err;
> > +
> > +		bitmap_set(priv->valid_ports, pn, 1);
> 
> set_bit(pn, priv->valid_ports) ?

If you don't need it to be atomic, then please use __set_bit().

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

      reply	other threads:[~2025-03-10 18:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09 23:25 [PATCH net-next v9] net: mdio: Add RTL9300 MDIO driver Chris Packham
2025-03-10  1:31 ` Daniel Golle
2025-03-10  2:07   ` Chris Packham
2025-03-10 15:28     ` Daniel Golle
2025-03-13  1:04       ` Chris Packham
2025-03-13 13:05         ` Andrew Lunn
2025-03-10 16:32     ` Andrew Lunn
2025-03-10 16:34     ` Russell King (Oracle)
2025-03-10 16:27   ` Andrew Lunn
2025-03-10 18:06 ` Christophe JAILLET
2025-03-10 18:15   ` Russell King (Oracle) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z88sJSzFTmYMvsZL@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.stockhausen@gmx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sander@svanheule.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.