From: Sean Christopherson <seanjc@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Zheyun Shen <szy0127@sjtu.edu.cn>,
Tom Lendacky <thomas.lendacky@amd.com>,
Kevin Loughlin <kevinloughlin@google.com>,
Mingwei Zhang <mizhang@google.com>
Subject: Re: [PATCH 2/7] x86, lib: Drop the unused return value from wbinvd_on_all_cpus()
Date: Thu, 27 Feb 2025 11:59:09 -0800 [thread overview]
Message-ID: <Z8DEDSsFbQjcisqr@google.com> (raw)
In-Reply-To: <20250227014858.3244505-3-seanjc@google.com>
On Wed, Feb 26, 2025, Sean Christopherson wrote:
> Drop wbinvd_on_all_cpus()'s return value; both the "real" version and the
> stub always return '0', and none of the callers check the return.
Drat. None of the callers _in my working tree_. I only checked a sparse working
tree and missed that the DRM code checks the return value. Luckily, it's uninteresting
code (and dead to boot). I'll add a patch to drop the checks on the return value.
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");
--
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");
--
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");
next prev parent reply other threads:[~2025-02-27 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 1:48 [PATCH 0/7] x86, KVM: Optimize SEV cache flushing Sean Christopherson
2025-02-27 1:48 ` [PATCH 1/7] KVM: SVM: Remove wbinvd in sev_vm_destroy() Sean Christopherson
2025-02-27 1:48 ` [PATCH 2/7] x86, lib: Drop the unused return value from wbinvd_on_all_cpus() Sean Christopherson
2025-02-27 19:59 ` Sean Christopherson [this message]
2025-02-27 1:48 ` [PATCH 3/7] x86, lib: Add WBNOINVD helper functions Sean Christopherson
2025-03-13 10:13 ` Huang, Kai
2025-02-27 1:48 ` [PATCH 4/7] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Sean Christopherson
2025-02-27 1:48 ` [PATCH 5/7] KVM: x86: Use wbinvd_on_cpu() instead of an open-coded equivalent Sean Christopherson
2025-03-03 16:49 ` Tom Lendacky
2025-02-27 1:48 ` [PATCH 6/7] x86, lib: Add wbinvd and wbnoinvd helpers to target multiple CPUs Sean Christopherson
2025-02-27 12:45 ` Zheyun Shen
2025-03-13 10:19 ` Huang, Kai
2025-02-27 1:48 ` [PATCH 7/7] KVM: SVM: Flush cache only on CPUs running SEV guest Sean Christopherson
2025-03-03 16:53 ` Tom Lendacky
2025-03-03 16:46 ` [PATCH 0/7] x86, KVM: Optimize SEV cache flushing Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8DEDSsFbQjcisqr@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kevinloughlin@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=szy0127@sjtu.edu.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.