All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: airlied@gmail.com, simona@ffwll.ch, tzimmermann@suse.de
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
	thierry.reding@gmail.com, mperttunen@nvidia.com,
	linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
Date: Fri, 28 Feb 2025 15:48:09 +0000	[thread overview]
Message-ID: <Z8HauW1ewQoz0iLh@gallifrey> (raw)
In-Reply-To: <0036ecec-8476-4617-ac40-8ff90fb33c07@kapsi.fi>

Hi,

* Mikko Perttunen (cyndis@kapsi.fi) wrote:
> On 12/16/24 6:47 AM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >   drivers/gpu/host1x/debug.c | 9 ---------
> >   drivers/gpu/host1x/debug.h | 1 -
> >   2 files changed, 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> > index a18cc8d8caf5..6433c00d5d7e 100644
> > --- a/drivers/gpu/host1x/debug.c
> > +++ b/drivers/gpu/host1x/debug.c
> > @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
> >   	show_all(host1x, &o, true);
> >   }
> > -
> > -void host1x_debug_dump_syncpts(struct host1x *host1x)
> > -{
> > -	struct output o = {
> > -		.fn = write_to_printk
> > -	};
> > -
> > -	show_syncpts(host1x, &o, false);
> > -}
> > diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> > index 62bd8a091fa7..c43c61d876a9 100644
> > --- a/drivers/gpu/host1x/debug.h
> > +++ b/drivers/gpu/host1x/debug.h
> > @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
> >   void host1x_debug_init(struct host1x *host1x);
> >   void host1x_debug_deinit(struct host1x *host1x);
> >   void host1x_debug_dump(struct host1x *host1x);
> > -void host1x_debug_dump_syncpts(struct host1x *host1x);
> >   #endif
> 
> Acked-by: Mikko Perttunen <mperttunen@nvidia.com>

Can this find it's way into drm please.

Thanks,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2025-02-28 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15 21:47 [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts linux
2024-12-17  7:24 ` Mikko Perttunen
2025-02-28 15:48   ` Dr. David Alan Gilbert [this message]
2025-02-28 16:46 ` Thierry Reding
2025-02-28 18:15   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8HauW1ewQoz0iLh@gallifrey \
    --to=linux@treblig.org \
    --cc=airlied@gmail.com \
    --cc=cyndis@kapsi.fi \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.