From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF5523F396; Fri, 28 Feb 2025 21:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740777298; cv=none; b=cMCE//O40tZc8P0ELer5drX0avZqJfVyLvZP3IAdA57Dhnj/yoU+aXHjmMW7xIXT+WBe+3vUZC1fw4MGtis0Gli3pxN/uiHxZ649qHadoplBLLjx/Twe5Qnb70kzqnJngj5wcWGcOxGub9mWFnhDV7mByY7Pg3xsgqRMDEDia6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740777298; c=relaxed/simple; bh=0XgvGcjUrAwi1kFAHtODcTmPecLThdWEAGMsndHtRX8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uFgkF65ZFE4mtoLem7K+YCGf3jKbiK3f9teTx83soBg0sL64VjnMG8uP+0ZuV9aNFn/zOedrBD5XE3K5jcM40REK/GLyc38KHrtjF4BUTZjGB5j4997PlTmKw3Yj8v4u5sEQw4WErTruoWyJiVv+A3GWtkQ3SMtVnjxko5q9rSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cheX9VB2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cheX9VB2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA09CC4CED6; Fri, 28 Feb 2025 21:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740777298; bh=0XgvGcjUrAwi1kFAHtODcTmPecLThdWEAGMsndHtRX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cheX9VB2F3cFfRmd1Gl4lfeCdap+/XacJavAsuSIa7b6/C/97Zs6/73MrYyujhUP2 1/s18H/+T2RML+Qv+ZeQseAuPFo2DDH06MYebP5r0U/+zfcw1vU+qdv0dQjsJCI6kh 2EMwywYjZ3cVDURu1+JKp5h/5Bfe7Okha0HVf2e9gVuCPULwBHf+4TK0gaCib5bQGJ haysqSwmm6uY0+gOxm2F72qzHCjKYU2dl6IRPW44OYEKIZ7Cjp5IJpEgC2tnD0bkCq KqfM4lEm4+ZKOLAe8PTlcIjuvgeI6x2jCGiBqEnu9lWoG2yIT+08mSSqahe+N4Kt6N JVFZaZCoqpg4w== Date: Fri, 28 Feb 2025 11:14:56 -1000 From: Tejun Heo To: Alexei Starovoitov Cc: Juntong Deng , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eddy Z , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Kumar Kartikeya Dwivedi , David Vernet , Andrea Righi , Changwoo Min , bpf , LKML Subject: Re: [PATCH sched_ext/for-6.15 v3 3/5] sched_ext: Add scx_kfunc_ids_ops_context_sensitive for unified filtering of context-sensitive SCX kfuncs Message-ID: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello, On Thu, Feb 27, 2025 at 06:38:32PM -0800, Alexei Starovoitov wrote: ... > > > Not from this change but these can probably be allowed from TRACING too. > > > > > > > Not sure if it is safe to make these kfuncs available in TRACING. > > If Alexei sees this email, could you please leave a comment? > > Hold on, you want to enable all of scx_kfunc_ids_unlocked[] set > to all of TRACING ? What is the use case ? I thought it may be useful to be able to iterate DSQs and trigger dispatching from there but > Maybe it's safe, but without in-depth analysis we shouldn't. > Currently sched-ext allows scx_kfunc_set_any[] for tracing. > I would stick to that in this patch set. I haven't thought through about safety at all and was mostly naively thinking that if _any is safe _unlocked should too. Right now, unlocked has two groups of kfuncs - the ones that should be able to sleep and the ones that can be called from within scx_dsq_iter iterations. The former is excluded from TRACING through KF_SLEEPABLE, I think. I don't know whether dsq iteration is allowed in TRACING. Anyways, not a real issue either way. Thanks. -- tejun