From: Yao Zi <ziyao@disroot.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: "Tom Rini" <trini@konsulko.com>,
"Jerome Forissier" <jerome.forissier@linaro.org>,
"Simon Glass" <sjg@chromium.org>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Rick Chen" <rick@andestech.com>, Leo <ycliang@andestech.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Matthias Brugger" <mbrugger@suse.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Adriano Cordova" <adrianox@gmail.com>,
"Sughosh Ganu" <sughosh.ganu@linaro.org>,
"Vincent Stehlé" <vincent.stehle@arm.com>,
"Janne Grunau" <j@jannau.net>,
"U-Boot Mailing List" <u-boot@lists.denx.de>
Subject: Re: [PATCH 2/5] arm: include asm-generic/int-ll64.h in setjmp.h
Date: Sun, 2 Mar 2025 16:20:37 +0000 [thread overview]
Message-ID: <Z8SFVXBCSXQmZpfm@pie.lan> (raw)
In-Reply-To: <CAM=mAOktvhQ4Rq1Z=hQENCx3LR87XXoKq_bK2hL1ct1qiSww6Q@mail.gmail.com>
On Sun, Mar 02, 2025 at 05:18:21PM +0100, Heinrich Schuchardt wrote:
> Yao Zi <ziyao@disroot.org> schrieb am So., 2. März 2025, 17:02:
>
> > On Sun, Mar 02, 2025 at 03:21:18PM +0100, Heinrich Schuchardt wrote:
> > > Don't assume that u32 and u64 are already defined.
> > >
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > > ---
> > > arch/arm/include/asm/setjmp.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm/include/asm/setjmp.h
> > b/arch/arm/include/asm/setjmp.h
> > > index 662bec86321..9a7f5af9f8f 100644
> > > --- a/arch/arm/include/asm/setjmp.h
> > > +++ b/arch/arm/include/asm/setjmp.h
> > > @@ -7,6 +7,8 @@
> > > #ifndef _SETJMP_H_
> > > #define _SETJMP_H_ 1
> > >
> > > +#include <asm-generic/int-ll64.h>
> > > +
> >
> > > /*
> > > * This really should be opaque, but the EFI implementation wrongly
> > > * assumes that a 'struct jmp_buf_data' is defined.
> >
> > With PATCH 4 of the series, this comment isn't true anymore. Should we
> > fix it up at the same time?
> >
>
> The comment is removed in patch 3.
Oops, I didn't notice that. Sorry for the noise.
> https://lore.kernel.org/u-boot/20250302142121.150480-4-heinrich.schuchardt@canonical.com/T/#u
>
> Best regards
>
> Heinrich
Thanks,
Yao Zi
next prev parent reply other threads:[~2025-03-02 16:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 14:21 [PATCH 0/5] common: clean up usage of structure jmp_buf_data Heinrich Schuchardt
2025-03-02 14:21 ` [PATCH 1/5] sandbox: remove linux/types.h dependency in setjmp.h Heinrich Schuchardt
2025-03-04 13:48 ` Jerome Forissier
2025-03-02 14:21 ` [PATCH 2/5] arm: include asm-generic/int-ll64.h " Heinrich Schuchardt
2025-03-02 16:01 ` Yao Zi
2025-03-02 16:18 ` Heinrich Schuchardt
2025-03-02 16:20 ` Yao Zi [this message]
2025-03-04 13:48 ` Jerome Forissier
2025-03-11 12:44 ` Ilias Apalodimas
2025-03-02 14:21 ` [PATCH 3/5] common: clean up setjmp.h Heinrich Schuchardt
2025-03-04 13:49 ` Jerome Forissier
2025-03-02 14:21 ` [PATCH 4/5] efi_loader: Clean up usage of structure jmp_buf_data Heinrich Schuchardt
2025-03-04 13:49 ` Jerome Forissier
2025-03-04 13:51 ` Ilias Apalodimas
2025-03-02 14:21 ` [PATCH 5/5] arm: use type jmp_buf instead of struct jmp_buf_data Heinrich Schuchardt
2025-03-04 13:49 ` Jerome Forissier
2025-03-04 13:51 ` Ilias Apalodimas
2025-03-04 9:10 ` [PATCH 0/5] common: clean up usage of structure jmp_buf_data Jerome Forissier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8SFVXBCSXQmZpfm@pie.lan \
--to=ziyao@disroot.org \
--cc=adrianox@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=ilias.apalodimas@linaro.org \
--cc=j@jannau.net \
--cc=jerome.forissier@linaro.org \
--cc=kever.yang@rock-chips.com \
--cc=mbrugger@suse.com \
--cc=patrice.chotard@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rick@andestech.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vincent.stehle@arm.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.