From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lee@kernel.org, giometti@enneenne.com,
gregkh@linuxfoundation.org, raymond.tan@intel.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO
Date: Mon, 3 Mar 2025 13:38:15 +0200 [thread overview]
Message-ID: <Z8WUpzDHbhp0aMoN@black.fi.intel.com> (raw)
In-Reply-To: <Z8VmebNcrH6CjHp6@smile.fi.intel.com>
On Mon, Mar 03, 2025 at 10:21:13AM +0200, Andy Shevchenko wrote:
> On Mon, Mar 03, 2025 at 10:17:42AM +0530, Raag Jadav wrote:
> > Now that we have Intel MFD driver for PSE GPIO, depend on it.
>
> ...
>
> > config GPIO_ELKHARTLAKE
> > tristate "Intel Elkhart Lake PSE GPIO support"
> > - depends on X86 || COMPILE_TEST
> > + depends on (X86 && MFD_INTEL_EHL_PSE_GPIO) || COMPILE_TEST
> > select GPIO_TANGIER
>
> Looking on how GPIO PMIC drivers are written, I would redo this as
>
> depends on (X86 || COMPILE_TEST) && MFD_INTEL_EHL_PSE_GPIO
True, but perhaps allow independent COMPILE_TEST where possible?
Raag
next prev parent reply other threads:[~2025-03-03 11:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 4:47 [PATCH v2 0/5] Introduce Intel Elkhart Lake PSE TIO Raag Jadav
2025-03-03 4:47 ` [PATCH v2 1/5] mfd: intel_ehl_pse_gpio: Introduce Intel Elkhart Lake PSE GPIO and TIO Raag Jadav
2025-03-03 8:24 ` Andy Shevchenko
2025-03-03 11:39 ` Raag Jadav
2025-03-03 11:45 ` Andy Shevchenko
2025-03-03 12:14 ` Raag Jadav
2025-03-03 12:22 ` Andy Shevchenko
2025-03-03 12:47 ` Raag Jadav
2025-03-03 13:20 ` Andy Shevchenko
2025-03-04 5:25 ` Raag Jadav
2025-03-04 11:33 ` Andy Shevchenko
2025-03-03 4:47 ` [PATCH v2 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO Raag Jadav
2025-03-03 8:21 ` Andy Shevchenko
2025-03-03 11:38 ` Raag Jadav [this message]
2025-03-03 11:44 ` Andy Shevchenko
2025-03-03 12:13 ` Raag Jadav
2025-03-03 12:21 ` Andy Shevchenko
2025-03-03 12:46 ` Raag Jadav
2025-03-03 13:19 ` Andy Shevchenko
2025-03-03 14:01 ` Raag Jadav
2025-03-03 14:20 ` Andy Shevchenko
2025-03-04 5:22 ` Raag Jadav
2025-03-04 11:31 ` Andy Shevchenko
2025-03-04 14:24 ` Andy Shevchenko
2025-03-03 4:47 ` [PATCH v2 3/5] pps: generators: tio: split pps_gen_tio.h Raag Jadav
2025-03-03 4:47 ` [PATCH v2 4/5] pps: generators: tio: move to match_data() model Raag Jadav
2025-03-03 4:47 ` [PATCH v2 5/5] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8WUpzDHbhp0aMoN@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.