From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE125661 for ; Mon, 3 Mar 2025 12:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741005199; cv=none; b=rQMYUEQFJWWBahKLv113CgonGGAMKVW7fhFebSJ1aas2QKmhd7QUwGO4d9Ixo6GRcagbSObLdSXAl/SgJfNbYDU0XOohMeHJHrTcg8JnfeP547AszIr0uaDxJFUAdUEzjtt3zL9fb/VYZNxHYsbhKlsDWebKxxLKwNbc6yVVCic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741005199; c=relaxed/simple; bh=x9SEbmFJPq62LJOYO+aRF/L+53QttHd8dBpeE2pMwrQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k78qJuFGNJ6yWPqauu8yMMytVFXWg+F1oHElJRZrrRjXPL66ucdTTsV8OY4TnEBoK0348kom8uqjOI9J4zvLIxGFiFPoM6T1ZIpG/kXXpPps0hTpbJv0mvsSWiZCd39TFllTyDtBybxl8uffSrak1cJAjjjnrbmZWLTPbIzEtYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qgad3ie1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qgad3ie1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E91FC4CED6; Mon, 3 Mar 2025 12:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741005197; bh=x9SEbmFJPq62LJOYO+aRF/L+53QttHd8dBpeE2pMwrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qgad3ie1d+F48UWQikUiSMHknHCw/FUCVeasoQdNnbjUasylxuyoJHw0AiApXA0/e O8HxrPdpr4G2lTEuO8guMUDlLWJkPRkJ2vZYy7DGlqvN1Y1xWBYbeHnB7zZAFFVAK0 /CyK3sC7AuC+nODDrXAKTJ5YDL2lKofIQKaeYITSOkJF5xeHgsPW2+gUz5zmfRcFmd ceJHe6y5iHGrKJEvcwqzJBo8CRgE3zjYjtFXHvfR0I65wa+hOVjtprh6m7zI5xkGYP 6SlLeVysL95CyO9mBH29ZTqobIgDtGLva0/bSoUu1crRSHSZhmm0iRZg1MTIBQC98K VYJ9A4JSg4qfw== Date: Mon, 3 Mar 2025 13:33:12 +0100 From: Ingo Molnar To: Jinjie Ruan Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, xin3.li@intel.com, krisman@collabora.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP Message-ID: References: <20241030012438.358269-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241030012438.358269-1-ruanjinjie@huawei.com> * Jinjie Ruan wrote: > Since following commit, _TIF_SINGLESTEP is not used by x86 anymore, > remove it. > > Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return") > Signed-off-by: Jinjie Ruan > --- > arch/x86/include/asm/thread_info.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h > index 12da7dfd5ef1..734db7221613 100644 > --- a/arch/x86/include/asm/thread_info.h > +++ b/arch/x86/include/asm/thread_info.h > @@ -110,7 +110,6 @@ struct thread_info { > #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME) > #define _TIF_SIGPENDING (1 << TIF_SIGPENDING) > #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED) > -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP) > #define _TIF_SSBD (1 << TIF_SSBD) > #define _TIF_SPEC_IB (1 << TIF_SPEC_IB) > #define _TIF_SPEC_L1D_FLUSH (1 << TIF_SPEC_L1D_FLUSH) While technically _TIF_SINGLESTEP is not used, TIF_SINGLESTEP is very much used, and _TIF_SINGLESTEP is its canonical mask definition that we construct for all the other TIF bits as well. Thanks, Ingo