From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Saeed Mahameed <saeed@kernel.org>
Subject: Re: [PATCH net-next v10 04/14] net: hold netdev instance lock during qdisc ndo_setup_tc
Date: Mon, 3 Mar 2025 07:35:45 -0800 [thread overview]
Message-ID: <Z8XMUWqZT_AiemQz@mini-arch> (raw)
In-Reply-To: <CAM0EoMkj=s+0G7AkCBdgBp5vM3xhusUpuX3D+oQZL+hWPFSJjA@mail.gmail.com>
On 03/02, Jamal Hadi Salim wrote:
> On Sat, Mar 1, 2025 at 7:09 PM Stanislav Fomichev <sdf@fomichev.me> wrote:
> >
> > Qdisc operations that can lead to ndo_setup_tc might need
> > to have an instance lock.
>
> Sorry, havent followed this work - "might need" here means that
> sometimes it may and sometimes it may not need the device instance
> lock (I suppose depending on the driver)?
Yes, depending on the driver we might grab the instance lock now, see
[0] for more details. One thing we might consider doing here is to
grab instance lock only if the underlying driver uses tc offloads
(has ndo_setup_tc), but I didn't want to over-complicate things.
0: https://lore.kernel.org/netdev/CAPpAL=w0+x1Mj3iHRkeiktXjY3FTt-pz9qHk9f0KF-EL2FOCxw@mail.gmail.com/T/#m76b928e4adb87aac30dda7e51b331712a3c0c2e3
> Since i dont know enough about the motivation for the instance lock, I
> just reviewed for consistency and for that:
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Ty!
next prev parent reply other threads:[~2025-03-03 15:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 0:08 [PATCH net-next v10 00/14] net: Hold netdev instance lock during ndo operations Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 01/14] net: hold netdev instance lock during ndo_open/ndo_stop Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 02/14] net: hold netdev instance lock during nft ndo_setup_tc Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 03/14] net: sched: wrap doit/dumpit methods Stanislav Fomichev
2025-03-02 20:49 ` Jamal Hadi Salim
2025-03-03 15:33 ` Stanislav Fomichev
2025-03-04 16:43 ` Jamal Hadi Salim
2025-03-04 20:53 ` Cong Wang
2025-03-02 0:08 ` [PATCH net-next v10 04/14] net: hold netdev instance lock during qdisc ndo_setup_tc Stanislav Fomichev
2025-03-02 20:56 ` Jamal Hadi Salim
2025-03-03 15:35 ` Stanislav Fomichev [this message]
2025-03-02 0:08 ` [PATCH net-next v10 05/14] net: hold netdev instance lock during queue operations Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 06/14] net: hold netdev instance lock during rtnetlink operations Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 07/14] net: hold netdev instance lock during ioctl operations Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 08/14] net: hold netdev instance lock during sysfs operations Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 09/14] net: hold netdev instance lock during ndo_bpf Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 10/14] net: ethtool: try to protect all callback with netdev instance lock Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 11/14] net: replace dev_addr_sem " Stanislav Fomichev
2025-03-02 0:08 ` [PATCH net-next v10 12/14] net: add option to request " Stanislav Fomichev
2025-03-02 0:09 ` [PATCH net-next v10 13/14] docs: net: document new locking reality Stanislav Fomichev
2025-03-02 0:09 ` [PATCH net-next v10 14/14] eth: bnxt: remove most dependencies on RTNL Stanislav Fomichev
2025-03-03 4:22 ` [PATCH net-next v10 00/14] net: Hold netdev instance lock during ndo operations Lei Yang
-- strict thread matches above, loose matches on Subject: below --
2025-03-05 16:37 Stanislav Fomichev
2025-03-05 16:37 ` [PATCH net-next v10 04/14] net: hold netdev instance lock during qdisc ndo_setup_tc Stanislav Fomichev
2025-03-13 8:51 ` Eric Dumazet
2025-03-13 9:11 ` Stanislav Fomichev
2025-05-05 13:41 ` Cosmin Ratiu
2025-05-05 15:07 ` Stanislav Fomichev
2025-05-05 15:12 ` Cosmin Ratiu
2025-05-05 18:35 ` Jakub Kicinski
2025-05-05 18:54 ` Stanislav Fomichev
2025-05-05 19:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8XMUWqZT_AiemQz@mini-arch \
--to=stfomichev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=sdf@fomichev.me \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.