From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36789C282CD for ; Mon, 3 Mar 2025 15:53:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A813E10E47E; Mon, 3 Mar 2025 15:53:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LQJYKHSI"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 850F710E47E for ; Mon, 3 Mar 2025 15:53:13 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 12503611F7; Mon, 3 Mar 2025 15:53:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54DBDC4CED6; Mon, 3 Mar 2025 15:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741017190; bh=ORKfRgQGW0056hFlRKXF0EJAyVhkyKhngGPxX2PqvPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LQJYKHSIhCc+zkDJOINw/+gYZGMW1saFycpp7jykJx/liPxunoNS1bYapqJy44Tzl 0YosxQCdFCdm2eNMkXF1Fb7YD90Oz1f3sRmTJNk19aLiDl6sBfIPAOcukqaH1FZJnp hZ3FIIiGJxLNftS0do9jClz/yzcyfj+Nb0iyZdl9IYtxp3XK2JPTuKlrRY4t/y+H1r SKB4cIQAAkANGYzq4lIZruJlr66Mhui6H0DVEXFmmdLV3s3K49n7hckYbJCF+myC5m PifzLKwMGjvQJeEUR/Z/vKygTPm5o01XKWIWCX4DmtxfYO923kJFOa21DH2U6Bmj9i gO2Z1CUOzl8gQ== Date: Mon, 3 Mar 2025 16:53:05 +0100 From: Danilo Krummrich To: phasta@kernel.org Cc: Matthew Brost , Christian =?iso-8859-1?Q?K=F6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/sched: Fix outdated comments referencing thread Message-ID: References: <20250225131332.83415-2-phasta@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 03, 2025 at 04:48:36PM +0100, Philipp Stanner wrote: > On Tue, 2025-02-25 at 14:53 +0100, Danilo Krummrich wrote: > > On Tue, Feb 25, 2025 at 02:13:32PM +0100, Philipp Stanner wrote: > > > > - * is parked at which point it's safe. > > > + * drm_sched_cleanup_jobs. It will be reinserted > > > back after the > > > + * scheduler's workqueues are stopped at which > > > point it's safe. > > > > You don't know whether the workqueues are "stopped". I think you want > > to say > > that run_job / free_job work isn't scheduled or running. > > How about "after the scheduler's work items have been cancelled"? Sure, that's fine too. But be aware that you may have to change this wording in case another (unrelated) work item is gets added to the scheduler for some reason.