All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>, git@vger.kernel.org
Subject: Re: [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch
Date: Tue, 4 Mar 2025 08:32:55 +0100	[thread overview]
Message-ID: <Z8aspywaD0mAyHwd@pks.im> (raw)
In-Reply-To: <xmqq7c55vhj8.fsf@gitster.g>

On Mon, Mar 03, 2025 at 03:08:43PM -0800, Junio C Hamano wrote:
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
> 
> > Subject: Re: [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch
> 
> Hmph, instead use "--rfc=GSoC" to do [GSoC PATCH n/m] and please do
> not pile more "extra" on top?

I do understand though that `--rfc=GSoC` is not exactly discoverable for
a newcomer. Maybe a simpler fix would be to introduce an alias for that
option that is more discoverable? I don't have a great idea for how to
name it -- the best that comes to mind is `--patch-prefix`, which
mirrors `--subject-prefix`.

    --patch-prefix=<prefix>
    --rfc
        Prepends the string `<prefix>` to the subject prefix. As the
        subject prefix defaults to "PATCH", you’ll get "<prefix> PATCH"
        by default.

        When `--rfc` is given, the prefix will be set to "RFC" . RFC
        means "Request For Comments"; use this when sending an
        experimental patch for discussion rather than application.
        "--rfc=WIP" may also be a useful way to indicate that a patch is
        not complete yet ("WIP" stands for "Work In Progress").

        If the convention of the receiving community for a particular
        extra string is to have it after the subject prefix, the string
        <prefix> can be prefixed with a dash ("-") to signal that the rest
        of the <prefix> string should be appended to the subject prefix
        instead, e.g., --patch-prefix='-(WIP)' results in "PATCH (WIP)".

We would hide away the optional value `[=<rfc>]` of the `--rfc` option
and instead advertise `--patch-prefix=<prefix>`. This would of course
only be a cosmetic change, we'd still accept the optional argument so
that we don't break backwards compatibility.

Patrick

  reply	other threads:[~2025-03-04  7:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 22:00 [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 1/6] builtin/log: add subject-extra-prefix " Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 2/6] builtin/log: die if -k and --suject-extra-prefix are used together Lucas Seiki Oshiro
2025-03-03 22:36   ` Eric Sunshine
2025-03-03 22:00 ` [GSoC][RFC PATCH 3/6] revision: add subject_extra_field to struct rev_info Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 4/6] builtin/log: fill subject extra prefix in format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 5/6] log-tree: add subject prefix in output email subject Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 6/6] t4014: add tests for the new flag --subject-extra-prefix Lucas Seiki Oshiro
2025-03-03 23:08 ` [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Junio C Hamano
2025-03-04  7:32   ` Patrick Steinhardt [this message]
2025-03-04 22:06     ` Junio C Hamano
2025-03-04 13:05   ` Junio C Hamano
2025-03-04 23:19     ` Lucas Seiki Oshiro
2025-03-05  2:06       ` Junio C Hamano
2025-03-05 14:26         ` Lucas Seiki Oshiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8aspywaD0mAyHwd@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lucasseikioshiro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.