From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
ilpo.jarvinen@linux.intel.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Ying Huang <huang.ying.caritas@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH] resource: Fix resource leak in get_free_mem_region()
Date: Tue, 4 Mar 2025 14:09:17 +0200 [thread overview]
Message-ID: <Z8btbTohCVzq16Qb@smile.fi.intel.com> (raw)
In-Reply-To: <20250304043415.610286-1-lizhijian@fujitsu.com>
On Tue, Mar 04, 2025 at 12:34:15PM +0800, Li Zhijian wrote:
> The leak is detected by the kernel memory leak detector (`kmemleak`)
> following a `cxl create-region` failure:
>
> cxl_acpi ACPI0017:00: decoder0.0: created region2
> cxl region2: HPA allocation error (-34) for size:0x0000000100000000 in CXL Window 0 [mem 0xa90000000-0x1a8fffffff flags 0x200]
> kmemleak: 1 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
>
> __kmalloc_cache_noprof+0x28c/0x350
> get_free_mem_region+0x45/0x380
> alloc_free_mem_region+0x1d/0x30
> size_store+0x180/0x290 [cxl_core]
The below lines have no importance to be present in the commit message.
Please read Submitting Patches documentation that justifies my comment.
> kernfs_fop_write_iter+0x13f/0x1e0
> vfs_write+0x37c/0x540
> ksys_write+0x68/0xe0
> do_syscall_64+0x6e/0x190
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-04 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 4:34 [PATCH] resource: Fix resource leak in get_free_mem_region() Li Zhijian
2025-03-04 9:22 ` Mika Westerberg
2025-03-04 9:44 ` Zhijian Li (Fujitsu)
2025-03-04 10:03 ` Mika Westerberg
2025-03-04 12:09 ` Andy Shevchenko [this message]
2025-03-04 23:43 ` Dan Williams
-- strict thread matches above, loose matches on Subject: below --
2025-03-05 2:22 Dan Williams
2025-03-05 2:54 ` Zhijian Li (Fujitsu)
2025-03-05 3:06 ` Dan Williams
2025-03-05 10:22 ` Andy Shevchenko
2025-03-14 11:49 ` Jonathan Cameron
2025-03-14 14:44 ` Andy Shevchenko
2025-06-04 6:06 ` Zhijian Li (Fujitsu)
2025-06-04 6:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8btbTohCVzq16Qb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=huang.ying.caritas@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.