From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E757C021B8 for ; Tue, 4 Mar 2025 12:29:09 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 76EA03C9FC3 for ; Tue, 4 Mar 2025 13:29:08 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 876FC3C6AD0 for ; Tue, 4 Mar 2025 13:28:52 +0100 (CET) Authentication-Results: in-6.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 8E8FA14291B7 for ; Tue, 4 Mar 2025 13:28:51 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E87A21190; Tue, 4 Mar 2025 12:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741091330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvU+V/zlOqVffYkVJ3SiyX7jVKKyF9aEm3tVKmTllXQ=; b=NvcTQyPvak8e+K7prZxicAxvxK3S/d4yI/6ia3eWNcQypfZ9wgKSwZkIGK3QpMnsIkG8Z0 YyDv2KAzTM3Kd70Y/wvre7174oOgU/8JPZhR3vo+ezjkPkhXoA1lrUofei56GfnFXENt0G 3il0m1SiVlTdHxcigAmUxZ/bu2WM+Gs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741091330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvU+V/zlOqVffYkVJ3SiyX7jVKKyF9aEm3tVKmTllXQ=; b=vp9fZ97USDftR+ZT6oBf2ZfBR257cNTw6FKj+uXVwFkbs8CXZHvk/Y8lJMaDjBHlqsjXkV +04vvlFu2pvSimCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NvcTQyPv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vp9fZ97U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741091330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvU+V/zlOqVffYkVJ3SiyX7jVKKyF9aEm3tVKmTllXQ=; b=NvcTQyPvak8e+K7prZxicAxvxK3S/d4yI/6ia3eWNcQypfZ9wgKSwZkIGK3QpMnsIkG8Z0 YyDv2KAzTM3Kd70Y/wvre7174oOgU/8JPZhR3vo+ezjkPkhXoA1lrUofei56GfnFXENt0G 3il0m1SiVlTdHxcigAmUxZ/bu2WM+Gs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741091330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvU+V/zlOqVffYkVJ3SiyX7jVKKyF9aEm3tVKmTllXQ=; b=vp9fZ97USDftR+ZT6oBf2ZfBR257cNTw6FKj+uXVwFkbs8CXZHvk/Y8lJMaDjBHlqsjXkV +04vvlFu2pvSimCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6CC901393C; Tue, 4 Mar 2025 12:28:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9Gg7GQLyxmdNCgAAD6G6ig (envelope-from ); Tue, 04 Mar 2025 12:28:50 +0000 Date: Tue, 4 Mar 2025 13:29:01 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20250110-lsm-v2-0-bd38035f86bc@suse.com> <20250110-lsm-v2-3-bd38035f86bc@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250110-lsm-v2-3-bd38035f86bc@suse.com> X-Rspamd-Queue-Id: 7E87A21190 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; MISSING_XM_UA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 3/7] Add lsm_get_self_attr02 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +static void setup(void) > +{ > + page_size = SAFE_SYSCONF(_SC_PAGESIZE); > + > + if (verify_enabled_lsm("selinux")) > + lsm_count++; > + > + if (verify_enabled_lsm("apparmor")) > + lsm_count++; > + > + if (verify_enabled_lsm("smack")) > + lsm_count++; This is the same as we have in the common.h (minus the TCONF there) maybe it would make more sense to split the function in common.h into two. One that would just return the number of lsm and second that would also call TCONF if it's zero. That way we could reuse the code here and keep the number of places with hardcoded security module names smaller. > +} > + > +static struct tst_test test = { > + .test_all = run, > + .setup = setup, > + .min_kver = "6.8", > +}; > > -- > 2.43.0 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp