Re: [PATCH 1/2] scsi-disk: Advertise FUA support by default

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Mar 04, 2025 at 03:52:31PM +0000, Alberto Faria wrote:
> FUA emulation code is already is place.
> 
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
>  hw/scsi/scsi-disk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index e7f738b484..8cf50845ab 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -3212,7 +3212,7 @@ static const Property scsi_hd_properties[] = {
>      DEFINE_PROP_BIT("removable", SCSIDiskState, features,
>                      SCSI_DISK_F_REMOVABLE, false),
>      DEFINE_PROP_BIT("dpofua", SCSIDiskState, features,
> -                    SCSI_DISK_F_DPOFUA, false),
> +                    SCSI_DISK_F_DPOFUA, true),

Should this come with machine type compat to prevent us advertizing FUA
to existing machine type versions ?

>      DEFINE_PROP_UINT64("wwn", SCSIDiskState, qdev.wwn, 0),
>      DEFINE_PROP_UINT64("port_wwn", SCSIDiskState, qdev.port_wwn, 0),
>      DEFINE_PROP_UINT16("port_index", SCSIDiskState, port_index, 0),

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|