From: Christoph Hellwig <hch@infradead.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
io-uring@vger.kernel.org, linux-xfs@vger.kernel.org,
wu lei <uwydoc@gmail.com>
Subject: Re: [PATCH v2 1/1] iomap: propagate nowait to block layer
Date: Tue, 4 Mar 2025 16:01:25 -0800 [thread overview]
Message-ID: <Z8eUVcqMYfCJtdge@infradead.org> (raw)
In-Reply-To: <6374c617-e9a3-4e1c-86ee-502356c46557@gmail.com>
On Tue, Mar 04, 2025 at 08:35:52PM +0000, Pavel Begunkov wrote:
> Clarification: the mentioned work was reverted or pulled out _upstream_,
> it wasn't about back porting.
I don't think we ever tried synchronous reporting of wouldblock errors,
but maybe i'm just too old and confused by now.
> lines. And Christoph even of confirmed that the main check in the patch
> does what's intended,
I absolutely did not.
> Another option is to push all io_uring filesystem / iomap requests
> to the slow path (where blocking is possible) and have a meaningful
> perf regression for those who still use fs+io_uring direct IO. And
> I don't put any dramaticism into it, it's essentially what users
> who detect the problem already do, either that but from the user
> space or disabling io_uring all together.
If you don't want to do synchronous wouldblock errors that's your
only option. I think it would suck badly, but it's certainly easier
to backport.
next prev parent reply other threads:[~2025-03-05 0:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 12:18 [PATCH v2 1/1] iomap: propagate nowait to block layer Pavel Begunkov
2025-03-04 16:07 ` Christoph Hellwig
2025-03-04 16:41 ` Pavel Begunkov
2025-03-04 16:59 ` Christoph Hellwig
2025-03-04 17:36 ` Jens Axboe
2025-03-04 23:26 ` Christoph Hellwig
2025-03-04 23:43 ` Jens Axboe
2025-03-04 23:49 ` Christoph Hellwig
2025-03-05 0:14 ` Pavel Begunkov
2025-03-05 0:18 ` Pavel Begunkov
2025-03-04 17:54 ` Pavel Begunkov
2025-03-04 23:28 ` Christoph Hellwig
2025-03-04 19:22 ` Darrick J. Wong
2025-03-04 20:35 ` Pavel Begunkov
2025-03-05 0:01 ` Christoph Hellwig [this message]
2025-03-05 0:45 ` Pavel Begunkov
2025-03-05 1:34 ` Christoph Hellwig
2025-03-04 21:11 ` Dave Chinner
2025-03-04 22:47 ` Pavel Begunkov
2025-03-04 23:40 ` Christoph Hellwig
2025-03-05 1:19 ` Dave Chinner
2025-03-05 14:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8eUVcqMYfCJtdge@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=uwydoc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.