From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v1 0/4] Input: Increase size of phys in the drivers
Date: Tue, 4 Mar 2025 23:18:52 -0800 [thread overview]
Message-ID: <Z8f63ImfQMB-Wp5R@google.com> (raw)
In-Reply-To: <Z8bulFaTKJ06YLrL@smile.fi.intel.com>
Hi Andy,
On Tue, Mar 04, 2025 at 02:14:12PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2025 at 02:07:43PM +0200, Andy Shevchenko wrote:
> > The drivers are using local member of 32 bytes to hold up to 40 (one-byte)
> > characters. GCC complains on that. This series fixes the issue in the affected
> > input drivers. Note, this is currently the biggest part of the warnings that
> > are being treated as errors with the default configurations on x86. With this
> > being applied we become quite close to enable CONFIG_WERROR=y (which is default
> > and basically reverted) in CIs. Clang, OTOH, has currently no issues with that.
>
> Would be nice to have a comment on this rather sooner as this impacts
> the compilation by `make W=1` with WERROR=y (which is default).
I do not like the change. There are no bugs, only GCC being paranoid.
Are there any other ways to shut it up? In [1] Jeff says that switching
to scnprintf() shuts GCC up...
[1] https://lore.kernel.org/r/Z3rIvp0hzS+yzvJA@nixie71
Thanks.
--
Dmitry
next prev parent reply other threads:[~2025-03-05 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 12:07 [PATCH v1 0/4] Input: Increase size of phys in the drivers Andy Shevchenko
2025-02-28 12:07 ` [PATCH v1 1/4] Input: ALPS - increase size of phys2 and phys3 Andy Shevchenko
2025-02-28 12:07 ` [PATCH v1 2/4] Input: atkbd - increase size of phys Andy Shevchenko
2025-02-28 12:07 ` [PATCH v1 3/4] Input: lifebook " Andy Shevchenko
2025-02-28 12:07 ` [PATCH v1 4/4] Input: psmouse " Andy Shevchenko
2025-02-28 12:52 ` [PATCH v1 0/4] Input: Increase size of phys in the drivers Andy Shevchenko
2025-03-04 12:14 ` Andy Shevchenko
2025-03-05 7:18 ` Dmitry Torokhov [this message]
2025-03-05 10:06 ` Andy Shevchenko
2025-03-26 9:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8f63ImfQMB-Wp5R@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.