From: Zhao Liu <zhao1.liu@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Dongli Zhang <dongli.zhang@oracle.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, pbonzini@redhat.com,
mtosatti@redhat.com, sandipan.das@amd.com, babu.moger@amd.com,
likexu@tencent.com, like.xu.linux@gmail.com,
zhenyuw@linux.intel.com, groug@kaod.org, khorenko@virtuozzo.com,
alexander.ivanov@virtuozzo.com, den@virtuozzo.com,
davydov-max@yandex-team.ru, dapeng1.mi@linux.intel.com,
joe.jin@oracle.com
Subject: Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
Date: Wed, 5 Mar 2025 22:41:47 +0800 [thread overview]
Message-ID: <Z8hiqwz4ExgWfRFR@intel.com> (raw)
In-Reply-To: <76da2b4a-2dc4-417c-91bc-ad29e08c8ba0@intel.com>
> > + if (has_pmu_cap && !X86_CPU(cpu)->enable_pmu) {
>
> One nit, it's safer to use
>
> (has_pmu_cap & KVM_PMU_CAP_DISABLE) && !X86_CPU(cpu)->enable_pmu
>
> Maybe we can rename has_pmu_cap to pmu_cap as well.
Yes, I agree.
Regards,
Zhao
next prev parent reply other threads:[~2025-03-05 14:21 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 22:00 [PATCH v2 00/10] target/i386/kvm/pmu: PMU Enhancement, Bugfix and Cleanup Dongli Zhang
2025-03-02 22:00 ` [PATCH v2 01/10] target/i386: disable PerfMonV2 when PERFCORE unavailable Dongli Zhang
2025-03-04 14:40 ` Xiaoyao Li
2025-03-04 22:53 ` dongli.zhang
2025-03-05 1:38 ` Xiaoyao Li
2025-03-05 14:20 ` Zhao Liu
2025-03-07 7:24 ` Sandipan Das
2025-03-02 22:00 ` [PATCH v2 02/10] target/i386: disable PERFCORE when "-pmu" is configured Dongli Zhang
2025-03-03 1:59 ` Xiaoyao Li
2025-03-03 18:45 ` dongli.zhang
2025-03-04 6:11 ` Xiaoyao Li
2025-03-06 16:50 ` Zhao Liu
2025-03-06 17:47 ` dongli.zhang
2025-03-07 7:41 ` Zhao Liu
2025-03-02 22:00 ` [PATCH v2 03/10] [DO NOT MERGE] kvm: Introduce kvm_arch_pre_create_vcpu() Dongli Zhang
2025-03-05 14:46 ` Zhao Liu
2025-03-05 21:53 ` dongli.zhang
2025-03-07 7:52 ` Zhao Liu
2025-03-07 8:40 ` Xiaoyao Li
2025-03-02 22:00 ` [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured Dongli Zhang
2025-03-04 7:59 ` Xiaoyao Li
2025-03-05 1:22 ` Sean Christopherson
2025-03-05 1:35 ` Xiaoyao Li
2025-03-05 14:41 ` Zhao Liu [this message]
2025-03-05 20:13 ` dongli.zhang
2025-03-05 14:44 ` Zhao Liu
2025-03-02 22:00 ` [PATCH v2 05/10] target/i386/kvm: extract unrelated code out of kvm_x86_build_cpuid() Dongli Zhang
2025-03-05 7:03 ` Mi, Dapeng
2025-03-07 9:15 ` Zhao Liu
2025-03-07 22:47 ` Dongli Zhang
2025-03-10 3:55 ` Zhao Liu
2025-03-02 22:00 ` [PATCH v2 06/10] target/i386/kvm: rename architectural PMU variables Dongli Zhang
2025-03-05 7:07 ` Mi, Dapeng
2025-03-07 9:19 ` Zhao Liu
2025-03-07 22:49 ` Dongli Zhang
2025-03-02 22:00 ` [PATCH v2 07/10] target/i386/kvm: query kvm.enable_pmu parameter Dongli Zhang
2025-03-10 6:14 ` Zhao Liu
2025-03-10 15:41 ` Dongli Zhang
2025-03-10 16:49 ` Dongli Zhang
2025-03-02 22:00 ` [PATCH v2 08/10] target/i386/kvm: reset AMD PMU registers during VM reset Dongli Zhang
2025-03-05 7:33 ` Mi, Dapeng
2025-03-05 11:41 ` Francesco Lavra
2025-03-05 19:05 ` dongli.zhang
2025-03-07 7:38 ` Sandipan Das
2025-03-10 7:47 ` Zhao Liu
2025-03-10 16:39 ` Dongli Zhang
2025-03-11 13:51 ` Zhao Liu
2025-03-11 19:52 ` Dongli Zhang
2025-03-12 8:30 ` Zhao Liu
2025-03-12 22:17 ` Dongli Zhang
2025-03-28 6:29 ` ewanhai
2025-03-28 16:42 ` Dongli Zhang
2025-03-31 3:55 ` ewanhai
2025-03-31 19:16 ` Dongli Zhang
2025-04-01 3:35 ` Ewan Hai
2025-04-07 8:51 ` Zhao Liu
2025-04-07 9:33 ` Ewan Hai
2025-04-16 8:17 ` Mi, Dapeng
2025-03-02 22:00 ` [PATCH v2 09/10] target/i386/kvm: support perfmon-v2 for reset Dongli Zhang
2025-03-02 22:00 ` [PATCH v2 10/10] target/i386/kvm: don't stop Intel PMU counters Dongli Zhang
2025-03-05 7:35 ` Mi, Dapeng
2025-03-05 19:00 ` dongli.zhang
2025-03-06 1:38 ` Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8hiqwz4ExgWfRFR@intel.com \
--to=zhao1.liu@intel.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=babu.moger@amd.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=davydov-max@yandex-team.ru \
--cc=den@virtuozzo.com \
--cc=dongli.zhang@oracle.com \
--cc=groug@kaod.org \
--cc=joe.jin@oracle.com \
--cc=khorenko@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=likexu@tencent.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sandipan.das@amd.com \
--cc=xiaoyao.li@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.