All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Gushchin <roman.gushchin@linux.dev>
To: Liu Ye <liuye@kylinos.cn>
Cc: akpm@linux-foundation.org, david@fromorbit.com,
	zhengqi.arch@bytedance.com, muchun.song@linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/shrinker: fix name consistency issue in shrinker_debugfs_rename()
Date: Wed, 5 Mar 2025 19:19:49 +0000	[thread overview]
Message-ID: <Z8ij1cHYljL_xQwg@google.com> (raw)
In-Reply-To: <20250305071759.661055-1-liuye@kylinos.cn>

On Wed, Mar 05, 2025 at 03:17:59PM +0800, Liu Ye wrote:
> After calling debugfs_change_name function, the return value should be
> checked and the old name restored. If debugfs_change_name fails, the new
> name memory should be freed. The effect is that the shrinker->name is not
> consistent with the name displayed in debugfs.
> 
> Signed-off-by: Liu Ye <liuye@kylinos.cn>
> Reviewed-by: Muchun Song <muchun.song@linux.dev>
> Reviewed-by：Qi Zheng <zhengqi.arch@bytedance.com>

Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>

Thanks!


      reply	other threads:[~2025-03-05 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05  7:17 [PATCH v2] mm/shrinker: fix name consistency issue in shrinker_debugfs_rename() Liu Ye
2025-03-05 19:19 ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8ij1cHYljL_xQwg@google.com \
    --to=roman.gushchin@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuye@kylinos.cn \
    --cc=muchun.song@linux.dev \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.