From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Maciej Strozek <mstrozek@opensource.cirrus.com>,
"Arnd Bergmann" <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
<linux-sound@vger.kernel.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: cs42l43: convert to SYSTEM_SLEEP_PM_OPS
Date: Thu, 6 Mar 2025 09:43:43 +0000 [thread overview]
Message-ID: <Z8luTwJBC3BdYZ8R@opensource.cirrus.com> (raw)
In-Reply-To: <20250305172738.3437513-1-arnd@kernel.org>
On Wed, Mar 05, 2025 at 06:27:32PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The custom suspend function causes a build warning when CONFIG_PM_SLEEP
> is disabled:
>
> sound/soc/codecs/cs42l43.c:2405:12: error: unused function 'cs42l43_codec_runtime_force_suspend' [-Werror,-Wunused-function]
>
> Change SET_SYSTEM_SLEEP_PM_OPS() to the newer SYSTEM_SLEEP_PM_OPS(),
> to avoid this.
>
> Fixes: 164b7dd4546b ("ASoC: cs42l43: Add jack delay debounce after suspend")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Apologies I should have spotted that in my review.
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-03-06 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 17:27 [PATCH] ASoC: cs42l43: convert to SYSTEM_SLEEP_PM_OPS Arnd Bergmann
2025-03-06 9:43 ` Charles Keepax [this message]
2025-03-06 13:59 ` Maciej Strozek
2025-03-06 16:10 ` Mark Brown
2025-03-12 22:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8luTwJBC3BdYZ8R@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.